feat: add version checking to CLI #2643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
Jun 24, 2022
Emyrk
reviewed
Jun 28, 2022
kylecarbs
reviewed
Jun 28, 2022
cli/root.go
Outdated
Comment on lines
382
to
385
| fmtWarningText := `client/server versions do not match | ||
| client version: %s | ||
| server version: %s | ||
| to download the appropriate version run 'curl -L https://coder.com/install.sh | sh -s -- --version %s' |
There was a problem hiding this comment.
I feel like we could shorten this up a bit. What do you think about:
version mismatch: client %s, server %s
download the server version with: ...
kylecarbs
approved these changes
Jun 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2578