Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: improve Users filter API #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJain AbhineetJain commented Jun 24, 2022

This PR fixes minor bugs and adds case-insensitive improvements to the User filter API.

Subtasks

  • allow case-insensitive matching for username, email, status and roles.
  • fix querying for role:member.
  • fix minor bugs: invalid error message, early return for invalid search query.
  • add unit tests

Addresses backend improvements for #595.

@AbhineetJain AbhineetJain requested review from Emyrk and f0ssel June 24, 2022 22:36
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Better UX

@AbhineetJain AbhineetJain enabled auto-merge (squash) June 24, 2022 23:48
@AbhineetJain AbhineetJain merged commit 90815e5 into main Jun 24, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/improve-user-filter branch June 24, 2022 23:55
@nadzeyav
Copy link

Hello @AbhineetJain , could you please add link to the issue that this Pull request is related to, if this is possible?

@AbhineetJain
Copy link
Contributor Author

This PR addresses backend improvements for #595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants