fix(coderd/x/chatd): ensure runner initializes from the db first - #26455
Merged
Conversation
hugodutka
force-pushed
the
hugodutka/runner-bootstrap-fix
branch
from
June 17, 2026 11:19
9364662 to
b0bd012
Compare
johnstcn
reviewed
Jun 17, 2026
johnstcn
approved these changes
Jun 17, 2026
hugodutka
force-pushed
the
hugodutka/runner-bootstrap-fix
branch
from
June 17, 2026 11:29
b0bd012 to
28e45f5
Compare
hugodutka
enabled auto-merge (squash)
June 17, 2026 11:30
mafredri
reviewed
Jun 17, 2026
| r.opts.Logger.Warn(ctx, "chatworker state update decode failed", slogError(err)) | ||
| return | ||
| } | ||
| <-bootstrapReady |
Member
There was a problem hiding this comment.
Should we select on r.ctx here as well (early exit)?
Contributor
Author
There was a problem hiding this comment.
not necessary since bootstrapReady is guaranteed to be closed when the outer function exits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close coder/internal#1589.