feat: Add filter on Users page #2653
Conversation
db1ab2e to
b94dba8
Compare
81dc68b to
63e35c2
Compare
|
Pumped on this |
| ])(`query=%p, filter=%p`, (query, filter) => { | ||
| expect(queryToFilter(query)).toEqual(filter) | ||
| }) | ||
| }) |
63e35c2 to
4717f84
Compare
1031696 to
bfbf729
Compare
| users: [], | ||
| roles: MockSiteRoles, | ||
| isLoading: true, | ||
| } |
There was a problem hiding this comment.
I like this story since it tests a particular behavior of the component, but I am not sure if it is a good UI snapshot since the loader is spinning and the snapshot may change across different builds. 🤔
There was a problem hiding this comment.
Good thought. I haven't read through this in detail, but could we pause the animation for the loader? Or introduce a slight delay? https://www.chromatic.com/docs/animations
There was a problem hiding this comment.
Thanks for pointing to this, I used
Loading.parameters = {
chromatic: { pauseAnimationAtEnd: true },
}and it seems to be constant for at least 3 builds.
| canEditUsers, | ||
| isLoading, | ||
| }) => { | ||
| const styles = useStyles() |
There was a problem hiding this comment.
I think this is so much clearer!!!!!!!!!!!! thank you!!!
|
Merging this now. If there are more concerns, we can handle them in a separate PR! 🎉 |
This PR adds a new filter to the Users page.
Subtasks
Fixes #595
Screenshots