Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: mark minimum-implicit-member experiment as safe - #26699

Merged
Emyrk merged 2 commits into
mainfrom
gateway-accounts/experiment-safe
Jun 25, 2026
Merged

feat: mark minimum-implicit-member experiment as safe#26699
Emyrk merged 2 commits into
mainfrom
gateway-accounts/experiment-safe

Conversation

@Emyrk

@Emyrk Emyrk commented Jun 25, 2026

Copy link
Copy Markdown
Member

Promotes ExperimentMinimumImplicitMember (Gateway Accounts) from the unsafe set into ExperimentsSafe so that deployments opting in with --experimental='*' enable it, and the experiment is advertised through the AvailableExperiments API used by the dashboard.

No functional changes to the experiment itself; this is the visibility flip that precedes user-facing documentation. Per docs/.style/content-guidelines.md, unsafe experiments do not get docs, so this PR is the prerequisite for the docs follow-up.

Refs #25936 (PLAT-217). Builds on the merged stack #25929, #25994, #26003, #26027.

Verification
  • go build ./codersdk/...
  • go test -run Test_Experiments -v ./coderd — all subtests pass (empty, wildcard, alternate_wildcard_with_manual_opt-in, multiple_features, available_experiments, Unauthorized).
  • go test -run TestExperimentsMetric -v ./coderd/prometheusmetrics — all subtests pass; the Unknown_experiment_is_not_exported_in_metrics subtest logs ignoring experiment "minimum-implicit-member"; it is not listed in expectations, which is the expected informational log.
Follow-up

Docs for the experiment (CLI flag mention, deployment configuration page, and the experiment's user-facing description) will follow in a separate PR once this lands.


Coder Agents on behalf of @Emyrk.

Promotes the minimum-implicit-member experiment (Gateway Accounts) from
the unsafe set into ExperimentsSafe so it is enabled via
--experimental='*' and exposed through the AvailableExperiments API.

This corresponds to the early access bar in
docs/.style/content-guidelines.md, where docs follow safe experiments.

Refs #25936 (PLAT-217).
@Emyrk
Emyrk marked this pull request as ready for review June 25, 2026 14:15

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a quick make gen

@coderagents

coderagents Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Documentation Check

This PR promotes minimum-implicit-member from unsafe to safe, making it user-visible. Per docs/.style/content-guidelines.md:

Safe experiments and Early Access features need at least a single docs page covering how to enable the feature, what it does, and known limitations.

The PR now includes an update to the auto-generated experiments table in docs/install/releases/feature-stages.md, which lists the experiment and its description. The PR body states a full docs page will follow in a separate PR. The content guidelines also state that documentation should land with the change.

New Documentation Needed

  • A dedicated docs page for the minimum-implicit-member experiment covering: how to enable it (--experiments=minimum-implicit-member), what it does (allows organizations to deviate from default organization-member roles, in support of Gateway Accounts), and known limitations.
    • This page should be added to docs/manifest.json.
    • Consider placing it under docs/admin/ or a relevant section for organization/role management.
    • Note: The auto-generated table entry in docs/install/releases/feature-stages.md is now present, but is not a substitute for a dedicated page per the content guidelines.

Automated review via Coder Agents

@github-actions

Copy link
Copy Markdown
Contributor

Docs preview

📖 View docs preview for docs/install/releases/feature-stages.md

@Emyrk Emyrk changed the title feat(codersdk): mark minimum-implicit-member experiment as safe feat: mark minimum-implicit-member experiment as safe Jun 25, 2026
@Emyrk
Emyrk merged commit 11efcc0 into main Jun 25, 2026
36 of 38 checks passed
@Emyrk
Emyrk deleted the gateway-accounts/experiment-safe branch June 25, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants