Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: move organization links out of admin menu - #26731

Closed
ametel01 wants to merge 10 commits into
coder:mainfrom
ametel01:fix/account-settings-organizations-nav
Closed

fix: move organization links out of admin menu#26731
ametel01 wants to merge 10 commits into
coder:mainfrom
ametel01:fix/account-settings-organizations-nav

Conversation

@ametel01

@ametel01 ametel01 commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Non-admin organization members can now reach Organizations from account/user settings instead of the Admin settings menu. Users with organization management permission still see Organizations under Admin settings.

Fixes #26695

AI assistance: Implemented with Codex and manually reviewed.

Visual coverage was added through Storybook states for NavbarView/ForOrganizationMember, MobileMenu/OrganizationMember, and UserDropdown/WithOrganizations.

@github-actions github-actions Bot added the community Pull Requests and issues created by the community. label Jun 25, 2026
@ametel01
ametel01 marked this pull request as ready for review June 25, 2026 23:11
@matifali

matifali commented Jun 30, 2026

Copy link
Copy Markdown
Member

Hi @ametel01, can you please fix the failing CI checks?

@ametel01 ametel01 changed the title fix(site): move organization links out of admin menu fix: move organization links out of admin menu Jun 30, 2026
@ametel01

ametel01 commented Jun 30, 2026

Copy link
Copy Markdown
Author

@matifali fixed the actionable CI issues:

  • Merged latest main into the branch and resolved the conflict.
  • Fixed the Storybook failure from missing PIXEL_KEY by skipping the Lost Pixel snapshot when the secret is unavailable to fork PRs.
  • Updated the PR title to fix: move organization links out of admin menu; the fresh title check is now passing.

The remaining BLOCKED state appears to be GitHub Actions approval for fork PR workflows (action_required with no jobs started), so it will need maintainer approval to run the full CI.

@ametel01

ametel01 commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

@matifali updated this so regular non-owner members do not see the Admin settings dropdown at all.

Desktop regular member view, including a user with admin-surface permissions but no site role:

Desktop:
Image

Mobile:
mobile-regular-member-admin-hidden

Organizations remains available from the user/account menu for users who can view orgs. Organization managers/admins still see Organizations under Admin settings.

matifali
matifali approved these changes Jul 2, 2026
View reviewed changes

@matifali matifali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributio. It looks good to me. I have asked internally for code reveiw too.

@matifali
matifali requested review from jakehwll and jeremyruppel July 2, 2026 16:05
@github-actions github-actions Bot added the stale This issue is like stale bread. label Jul 10, 2026
@ametel01

ametel01 commented Jul 12, 2026

Copy link
Copy Markdown
Author

Hi — just checking whether there’s anything else you need from me on this one. I saw the approval and the note about internal code review, so I’m happy to wait; I just wanted to make sure there isn’t a small follow-up or branch update I should handle from my side.

@github-actions github-actions Bot removed the stale This issue is like stale bread. label Jul 13, 2026
@jakehwll jakehwll mentioned this pull request Jul 15, 2026
Closed
@matifali Linear Code

matifali commented Jul 17, 2026

Copy link
Copy Markdown
Member

@zenithwolf1000 can we get a review on this? Thanks
I am fine with the UX it adds.

@tracyjohnsonux, can you also review from a Design/UX perspective?

@matifali

matifali commented Jul 22, 2026

Copy link
Copy Markdown
Member

Thanks for your contribution @ametel01. I am closing this in favor of #27251

@matifali matifali closed this Jul 22, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matifali matifali matifali approved these changes
@jdomeracki-coder jdomeracki-coder Awaiting requested review from jdomeracki-coder jdomeracki-coder is a code owner
@jeremyruppel jeremyruppel Awaiting requested review from jeremyruppel
@jakehwll jakehwll Awaiting requested review from jakehwll

Assignees

@ametel01 ametel01

Labels

community Pull Requests and issues created by the community.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: users should not see admin settings dropdown

2 participants

@ametel01 @matifali