fix: Check if start is nil before consuming in echo provisioner #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jun 27, 2022
| @@ -82,6 +82,10 @@ func (e *echo) Provision(stream proto.DRPCProvisioner_ProvisionStream) error { | |||
| return err | |||
| } | |||
| request := msg.GetStart() | |||
| if request == nil { | |||
| // A cancel could occur here! | |||
| return nil | |||
There was a problem hiding this comment.
Is the cancellation inferable via context, and if so, should we consider doing something like this here?
select {
case <-stream.Context().Done():
return stream.Context().Err()
default:
return errors.New("")
}There was a problem hiding this comment.
Nah, the cancelation isn't sent over the context at all. This should actually be fine because messages are handled synchronously, this one was just out of order!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused a race seen here:
https://github.com/coder/coder/runs/7074123929?check_suite_focus=true#step:10:217