-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: show Bedrock external ID in the provider edit form #26919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2573afa
f7178f5
ab9b110
d2d0bce
a3b92b7
d70b941
cbe4e03
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,6 +55,15 @@ export const isBedrockProvider = (provider: AIProvider): boolean => { | |
| return s !== null && s._type === BEDROCK_SETTINGS_TYPE; | ||
| }; | ||
|
|
||
| // Server-generated STS external ID; read-only. | ||
| export const bedrockExternalId = (provider: AIProvider): string | undefined => { | ||
| if (!isBedrockProvider(provider)) { | ||
| return undefined; | ||
| } | ||
| const s = provider.settings as SettingsWire | null; | ||
| return s?.external_id || undefined; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note [CRF-4] External ID lifecycle outlives the role ARN it was generated from.
If an admin once set a role ARN, then cleared it, the external ID persists server-side. The UI renders "Add it to the assumed role's trust policy" next to an empty Role ARN field. Not a bug per se: the external ID is valid for future role configurations, and the text is forward-looking. Worth knowing.
|
||
| }; | ||
|
|
||
| export const hasBedrockStoredCredentials = (provider: AIProvider): boolean => { | ||
| if (!isBedrockProvider(provider)) { | ||
| return false; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.