Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(coderd/x/chatd/chatloop): remove compaction timeout #27007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibetitsmike merged 1 commit into from
Jul 7, 2026
Merged

fix(coderd/x/chatd/chatloop): remove compaction timeout #27007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion coderd/x/chatd/chatloop/chatloop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@ type GenerateCompactionOptions struct {
ContextLimitFallback int64
SummaryPrompt string
SystemSummaryPrefix string
Timeout time.Duration
StepUsage fantasy.Usage
StepMetadata fantasy.ProviderMetadata

Expand Down
27 changes: 7 additions & 20 deletions coderd/x/chatd/chatloop/compaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,9 @@ const (
maxCompactionThresholdPercent = int32(100)

// compactionDebugCreateRunTimeout caps the compaction debug
// CreateRun budget so a slow or locked DB cannot consume the
// compaction's configured Timeout and cause model.Generate to
// fail with deadline exceeded. Debug instrumentation is
// best-effort; running without the debug row is preferable to
// failing the compaction.
// CreateRun budget. Debug instrumentation is best-effort;
// running without the debug row is preferable to blocking
// compaction on a slow or locked DB.
compactionDebugCreateRunTimeout = 5 * time.Second

defaultCompactionSummaryPrompt = "You are performing a context compaction. " +
Expand Down Expand Up @@ -54,15 +52,13 @@ const (
defaultCompactionSystemSummaryPrefix = "The following is a summary of " +
"the earlier conversation. The assistant was actively working when " +
"the context was compacted. Continue the work described below:"
defaultCompactionTimeout = 90 * time.Second
)

type CompactionOptions struct {
ThresholdPercent int32
ContextLimit int64
SummaryPrompt string
SystemSummaryPrefix string
Timeout time.Duration
Persist func(context.Context, CompactionResult) error
DebugSvc *chatdebug.Service
ChatID uuid.UUID
Expand Down Expand Up @@ -170,7 +166,6 @@ func normalizedCompactionGenerateConfig(opts GenerateCompactionOptions) (Compact
ContextLimit: opts.ContextLimit,
SummaryPrompt: opts.SummaryPrompt,
SystemSummaryPrefix: opts.SystemSummaryPrefix,
Timeout: opts.Timeout,
DebugSvc: opts.DebugSvc,
ChatID: opts.ChatID,
HistoryTipMessageID: opts.HistoryTipMessageID,
Expand All @@ -184,9 +179,6 @@ func normalizedCompactionGenerateConfig(opts GenerateCompactionOptions) (Compact
if strings.TrimSpace(config.SystemSummaryPrefix) == "" {
config.SystemSummaryPrefix = defaultCompactionSystemSummaryPrefix
}
if config.Timeout <= 0 {
config.Timeout = defaultCompactionTimeout
}
if config.ThresholdPercent < minCompactionThresholdPercent ||
config.ThresholdPercent > maxCompactionThresholdPercent {
config.ThresholdPercent = defaultCompactionThresholdPercent
Expand Down Expand Up @@ -285,11 +277,9 @@ func startCompactionDebugRun(
}

// Use a separate short-lived context for the debug insert so a
// slow or locked DB cannot consume the compaction timeout budget
// and turn debug slowness into a compaction failure via
// model.Generate hitting a deadline exceeded. Detached from the
// parent so cancellation of the compaction run still lets the
// insert reach a terminal state, matching the best-effort
// slow or locked DB cannot block the model call. Detached from
// the parent so cancellation of the compaction run still lets
// the insert reach a terminal state, matching the best-effort
// contract of debug instrumentation.
createRunCtx, createRunCancel := context.WithTimeout(
context.WithoutCancel(ctx), compactionDebugCreateRunTimeout,
Expand Down Expand Up @@ -360,10 +350,7 @@ func generateCompactionSummary(
})
toolChoice := fantasy.ToolChoiceNone

summaryCtx, cancel := context.WithTimeout(ctx, options.Timeout)
defer cancel()

summaryCtx, finishDebugRun := startCompactionDebugRun(summaryCtx, options)
summaryCtx, finishDebugRun := startCompactionDebugRun(ctx, options)
defer func() {
// If model.Generate (or anything else below) panics, the
// named err return is still nil at this point. Without the
Expand Down
32 changes: 31 additions & 1 deletion coderd/x/chatd/chatloop/compaction_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ func TestGenerateCompactionSummary_PanicFinalizesAsError(t *testing.T) {
DebugSvc: svc,
ChatID: chatID,
SummaryPrompt: "summarize",
Timeout: time.Second,
})
})

Expand All @@ -233,3 +232,34 @@ func TestGenerateCompactionSummary_PanicFinalizesAsError(t *testing.T) {
t.Fatal("FinalizeRun never reached UpdateChatDebugRun on panic")
}
}

func TestGenerateCompactionSummary_UsesCallerContext(t *testing.T) {
t.Parallel()

type contextKey string
testCtx := context.WithValue(context.Background(), contextKey("key"), "value")
var ctxSeen context.Context
model := &chattest.FakeModel{
ProviderName: "fake",
GenerateFn: func(ctx context.Context, _ fantasy.Call) (*fantasy.Response, error) {
ctxSeen = ctx
return &fantasy.Response{
Content: []fantasy.Content{
fantasy.TextContent{Text: "summary"},
},
}, nil
},
}

summary, err := generateCompactionSummary(testCtx, model,
[]fantasy.Message{textMessage(fantasy.MessageRoleUser, "hello")},
CompactionOptions{SummaryPrompt: "summarize"},
)
require.NoError(t, err)
require.Equal(t, "summary", summary)
require.Same(t, testCtx, ctxSeen)
require.NoError(t, ctxSeen.Err())
_, ok := ctxSeen.Deadline()
require.False(t, ok)
require.Equal(t, "value", ctxSeen.Value(contextKey("key")))
}
Loading