-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DNM: feat(coderd/database): add search parameter to GetChats #27009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
johnstcn
wants to merge
5
commits into
cian/codagt-722-dbpurge-sweep-to-backfill-and-maintain
from
cian/codagt-724-add-search-parameter-and-recency-ordering-to-getchats
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
676cb16
feat(coderd/database): add search parameter to GetChats
johnstcn 3e7d1d2
docs(coderd/database): tighten search comments
johnstcn eb282b9
refactor(coderd/database): address review on GetChats search
johnstcn 4904714
fix(coderd/database): treat whitespace-only GetChats search as empty
johnstcn 7b927dd
test(coderd/database): cover all eligible GetChats search message pairs
johnstcn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3 [CRF-13] The message search positive path covers only one of four eligible (role, visibility) pairs.
The SQL accepts
cm.role IN ('user', 'assistant') AND cm.visibility IN ('user', 'both'), giving four eligible combinations. Every positive message match on a root chat uses(user, both):msgChatat line 15365:ChatMessageRoleUser,ChatMessageVisibilityBothThe
assistantrole only appears onchildChat(line 15372), where the assertion tests child exclusion, not role eligibility. Theuservisibility (distinct fromboth) also only appears there.Fix: add one message with
(assistant, both)and one with(user, user)on root chats, each with a distinct search term, and add table cases asserting they match.(Bisky P3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue(fixed): Added root-chat fixtures for the three missing eligible pairs: (assistant, both), (user, user), and (assistant, user), each with a distinct term and a positive table case. Narrowing role or visibility in the SQL now fails the suite. Fixed in 7b927dd.
🤖 Reply posted by Coder Agents on behalf of @johnstcn.