feat(devtunnel): support geodistributed tunnels #2711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Jun 30, 2022
coderd/devtunnel/servers.go
Outdated
Comment on lines
30
to
43
| var TunnelRegions = []TunnelRegion{ | ||
| { | ||
| ID: 1, | ||
| LocationName: "US East Pittsburgh", | ||
| Nodes: []TunnelNode{ | ||
| { | ||
| ID: 1, | ||
| HostnameHTTPS: "pit-1.try.coder.app", | ||
| HostnameWireguard: "pit-1.try.coder.app", | ||
| WireguardPort: 55551, | ||
| }, | ||
| }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
It'd be nice if eventually this came from a server with a list of regions.
Comment on lines
+38
to
+39
| HostnameWireguard: "pit-1.try.coder.app", | ||
| WireguardPort: 55551, |
There was a problem hiding this comment.
These two fields could be returned by the server instead when it registers
kylecarbs
approved these changes
Jun 30, 2022
coderd/devtunnel/tunnel.go
Outdated
Comment on lines
274
to
281
| if cfg.Version == 0 { | ||
| cfg.Tunnel = TunnelNode{ | ||
| ID: 0, | ||
| HostnameHTTPS: "wg-tunnel.coder.app", | ||
| HostnameWireguard: "wg-tunnel-udp.coder.app", | ||
| WireguardPort: 55555, | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this v0 temporary while we upgrade?
There was a problem hiding this comment.
Yeah, this is the old tunnel config. Eventually I'll force people to upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.