feat(site/src/pages/TemplateBuilder): deselect modules using button in main content area instead of sidebar - #27113
Merged
aqandrew merged 3 commits intoJul 9, 2026
Conversation
aqandrew
commented
Jul 9, 2026
Contributor
Author
There was a problem hiding this comment.
It feels less than ideal that ModuleConfiguration has bg-surface-secondary, and <Button variant="outline"> has hover:bg-surface-secondary. So there's no visible hover state besides the cursor:
Screen.Recording.2026-07-08.at.6.22.20.PM.mov
Should we give these buttons bg-surface-primary?
Screen.Recording.2026-07-08.at.6.22.57.PM.mov
^There are a few places in the codebase that do this, like GitPanel and SessionTimeline. Wonder if adjusting outline buttons like this sitewide should be part of a larger design system convo
aqandrew
marked this pull request as draft
July 9, 2026 01:32
aqandrew
marked this pull request as ready for review
July 9, 2026 04:19
jeremyruppel
approved these changes
Jul 9, 2026
aqandrew
deleted the
aqandrew/template-builder-delete-modules-with-trash-can-icon
branch
July 9, 2026 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes DEVEX-588
Prototyped in #27077, broken off into a separate PR to make this work easier to track
changes
ModuleConfiguration(main content area)ModuleSelection(sidebar)context
@tracyjohnsonux and I decided in Slack that it would be a better UX to move the deletion action from the "x" icons in the sidebar to the trash can icons in the main content area. This change has the benefits of
ModuleSelection