-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(site): add Bedrock mantle protocol selector to provider form #27156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a23bc9e
feat(site): add Bedrock mantle protocol selector to provider form
evgeniy-scherbina aec3f81
Merge remote-tracking branch 'origin/main' into yevhenii/add-bedrock-…
evgeniy-scherbina 87bdcaf
fix(site): update bedrock protocol and base URL atomically on switch
evgeniy-scherbina 9e9a986
test(site): assert bedrock protocol switch rewrites endpoint and pres…
evgeniy-scherbina 4455552
test(site): assert mantle rejects an InvokeModel endpoint URL
evgeniy-scherbina 5fb2c5d
fix(site): name the protocol in the InvokeModel endpoint error
evgeniy-scherbina 68b0594
refactor(site): make bedrock default region a single source of truth
evgeniy-scherbina b02b0cf
refactor(site): derive the bedrock default base URL from its helper
evgeniy-scherbina 03857c2
🤖 refactor(site/src/pages/AISettingsPage/ProvidersPage/components): t…
jakehwll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note [CRF-6]
AddBedrockMantleseeds a state no user can reach:protocol: "mantle"with nobaseUrl, so it inherits the InvokeModel host fromtypeDefaults.bedrock. (Hisoka, Melody)The play asserts only that the hint text
/bedrock-mantle/irenders (the description, not the field value), so the mismatched endpoint goes unchecked. Seed a coherent mantlebaseUrland assert the endpoint field shows it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't fix, minor