Codestin Search App

rowansmithau · 2026-07-15T06:27:40Z

Summary

Root cause (confirmed by reading SecretDialog.tsx): the Value field on the User Secrets "Add secret"/"Edit secret" dialog was rendered as , a single-line HTML control, so pasting a multiline kubeconfig/PEM/YAML got visually collapsed and the newlines were lost before the value ever reached the form state or the API request.

Fix applied in site/src/pages/UserSettingsPage/SecretsPage/SecretDialog.tsx:

Swapped the Value field's for the same <Textarea> component already used for the Description field (which correctly preserves multiline text).
Added rows={4} so the box is usable for multiline content, and font-mono for readability of config-like values.
Kept the "mask typed value" obscuring behavior but switched -webkit-text-security:circle to :disc (Chromium's supported keyword for <textarea>; circle is input-specific and silently no-ops on textareas).
Removed the now-unused Input import.
All existing onFocus/onChange/onBlur masking/saved-value logic was preserved as-is; FormHelpers types already supported HTMLTextAreaElement, so no type changes were needed.

Test fix in site/src/pages/UserSettingsPage/SecretsPage/SecretsPageView.stories.tsx: the EditSecretClearValue story's toBeVisible() assertion on the helper text was racing the render/layout commit (this test already used a waitFor for an analogous transient-visibility check on the neighboring Clear button). The taller textarea shifted that timing enough to expose the race consistently when run as part of the full suite. Wrapped the assertion in waitFor(...) to match the existing pattern.

Created with the help of Mux and Sonnet, tested by a human

Working with a secret file like this:

➜  Downloads cat ~/.kube/config
apiVersion: v1
clusters:
  - cluster:
        certificate-authority-data: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUJkakNDQVIyZ0F3SUJBZ0lCQURBS0JnZ3Foa2pPUFFRREFqQWpNU0V3SHdZRFZRUUREQmhyTTNNdGMyVnkKZG1WeUxXTmhRREUzTWpBNU16VTFOelV3SGhjTk1qUXdOekUwTURVek9UTTFXaGNOTXpRd056RXlNRFV6T1RNMQpXakFqTVNFd0h3WURWUVFEREJock0zTXRjMlZ5ZG1WeUxXTmhRREUzTWpBNU16VTFOelV3V1RBVEJnY3Foa2pPClBRSUJCZ2dxaGtqT1BRTUJCd05DQUFTK1JRaUlLa0RVV0tKR0Y0ZFdnbWZSVTA1Wjg1ellQSWt6aWlHUXdBZ1gKMXdyQThhNVRRbzVuYlJmeWxRQXZtZDB1SE04a05GTmZIYXJwc3lxZkZyS0dvMEl3UURBT0JnTlZIUThCQWY4RQpCQU1DQXFRd0R3WURWUjBUQVFIL0JBVXdBd0VCL3pBZEJnTlZIUTRFRmdRVTBmUHdjMWpnd1BraFN2Q0cwbjQ1CnZTV09ES1V3Q2dZSUtvWkl6ajBFQXdJRFJ3QXdSQUlnQ3RCRm5KR0VJVVRSZ1RRaXZFSWJIODVwQnlMdmx1RjMKQ2ZTRFhDc3hlaWtDSUF4a0JKWnJ2eUUzQzNWRWdVT0t2d2VzVUN4cFBOendpbkg5Qkd4TXJuTk4KLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo=
        server: https://192.168.50.23:6443
    name: k3s-3-pi

Created via the UI in 2.35.1:

coder_dev=> select * from user_secrets;
-[ RECORD 1 ]+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
id           | 12853b89-a56b-408a-a9b0-11591ed04898
user_id      | 2702b6f3-b094-47ee-975e-47dc7887dbed
name         | kubeconfig
description  |
value        | apiVersion: v1 clusters:   - cluster:         certificate-authority-data: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUJkakNDQVIyZ0F3SUJBZ0lCQURBS0JnZ3Foa2pPUFFRREFqQWpNU0V3SHdZRFZRUUREQmhyTTNNdGMyVnkKZG1WeUxXTmhRREUzTWpBNU16VTFOelV3SGhjTk1qUXdOekUwTURVek9UTTFXaGNOTXpRd056RXlNRFV6T1RNMQpXakFqTVNFd0h3WURWUVFEREJock0zTXRjMlZ5ZG1WeUxXTmhRREUzTWpBNU16VTFOelV3V1RBVEJnY3Foa2pPClBRSUJCZ2dxaGtqT1BRTUJCd05DQUFTK1JRaUlLa0RVV0tKR0Y0ZFdnbWZSVTA1Wjg1ellQSWt6aWlHUXdBZ1gKMXdyQThhNVRRbzVuYlJmeWxRQXZtZDB1SE04a05GTmZIYXJwc3lxZkZyS0dvMEl3UURBT0JnTlZIUThCQWY4RQpCQU1DQXFRd0R3WURWUjBUQVFIL0JBVXdBd0VCL3pBZEJnTlZIUTRFRmdRVTBmUHdjMWpnd1BraFN2Q0cwbjQ1CnZTV09ES1V3Q2dZSUtvWkl6ajBFQXdJRFJ3QXdSQUlnQ3RCRm5KR0VJVVRSZ1RRaXZFSWJIODVwQnlMdmx1RjMKQ2ZTRFhDc3hlaWtDSUF4a0JKWnJ2eUUzQzNWRWdVT0t2d2VzVUN4cFBOendpbkg5Qkd4TXJuTk4KLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo=         server: https://192.168.50.23:6443     name: k3s-3-pi
env_name     |
file_path    | ~/.kube/config
created_at   | 2026-07-15 15:55:07.438234+10
updated_at   | 2026-07-15 15:55:07.438234+10
value_key_id |

Post change:

coder=# select * from user_secrets ;
-[ RECORD 1 ]+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
id           | 7c4858bc-ee87-45f0-b85d-0e9b1474d69c
user_id      | 0f0a590b-0358-4a24-bb25-ccc936bcc8d6
name         | kubeconfig
description  |
value        | apiVersion: v1                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          +
             | clusters:                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               +
             |   - cluster:                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            +
             |         certificate-authority-data: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUJkakNDQVIyZ0F3SUJBZ0lCQURBS0JnZ3Foa2pPUFFRREFqQWpNU0V3SHdZRFZRUUREQmhyTTNNdGMyVnkKZG1WeUxXTmhRREUzTWpBNU16VTFOelV3SGhjTk1qUXdOekUwTURVek9UTTFXaGNOTXpRd056RXlNRFV6T1RNMQpXakFqTVNFd0h3WURWUVFEREJock0zTXRjMlZ5ZG1WeUxXTmhRREUzTWpBNU16VTFOelV3V1RBVEJnY3Foa2pPClBRSUJCZ2dxaGtqT1BRTUJCd05DQUFTK1JRaUlLa0RVV0tKR0Y0ZFdnbWZSVTA1Wjg1ellQSWt6aWlHUXdBZ1gKMXdyQThhNVRRbzVuYlJmeWxRQXZtZDB1SE04a05GTmZIYXJwc3lxZkZyS0dvMEl3UURBT0JnTlZIUThCQWY4RQpCQU1DQXFRd0R3WURWUjBUQVFIL0JBVXdBd0VCL3pBZEJnTlZIUTRFRmdRVTBmUHdjMWpnd1BraFN2Q0cwbjQ1CnZTV09ES1V3Q2dZSUtvWkl6ajBFQXdJRFJ3QXdSQUlnQ3RCRm5KR0VJVVRSZ1RRaXZFSWJIODVwQnlMdmx1RjMKQ2ZTRFhDc3hlaWtDSUF4a0JKWnJ2eUUzQzNWRWdVT0t2d2VzVUN4cFBOendpbkg5Qkd4TXJuTk4KLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo=+
             |         server: https://192.168.50.23:6443                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              +
             |     name: k3s-3-pi
env_name     |
file_path    | ~/.kube/config
created_at   | 2026-07-15 15:49:08.772126+10
updated_at   | 2026-07-15 15:53:39.375332+10
value_key_id |

And displayed correct in the Coder workspace:

Add secret UI is now a multiline input box:

matifali · 2026-08-02T20:03:07Z

@jakehwll @dylanhuff-at-coder, can we get this reviewed? I think we should have this in the GA release.

dylanhuff-at-coder · 2026-08-03T16:19:42Z

 			</Label>
 			<div className="flex flex-col gap-2 sm:flex-row sm:items-start">
-				<Input
+				<Textarea


Can we add a story test that submits a multiline value and asserts it reaches onCreateSecret unchanged?

dylanhuff-at-coder

Overall lgtm, I would like to see a regression test added as noted, but wouldn't find that blocking

jakehwll · 2026-08-03T17:00:15Z

 			</Label>
 			<div className="flex flex-col gap-2 sm:flex-row sm:items-start">
-				<Input
+				<Textarea


resize-none might be a quick and easy enhancement here 🙂

jakehwll

LGTM

github-actions · 2026-08-03T20:04:51Z

Cherry-pick PR created: #27808

@dylanhuff-at-coder

Cherry-pick of #27253 Original PR: #27253 — fix: support adding multiline secrets via the UI Merge commit: f44e8c1 Requested by: @dylanhuff-at-coder Co-authored-by: Rowan Smith <[email protected]> Co-authored-by: Atif Ali <[email protected]>

fix for multiline secrets in the UI

40e3e7b

rowansmithau self-assigned this Jul 15, 2026

rowansmithau added bug ui labels Jul 15, 2026

rowansmithau changed the title ~~fix for multiline secrets in the UI~~ fix: support adding multiline secrets via the UI Jul 15, 2026

jakehwll self-requested a review July 21, 2026 05:56

jakehwll marked this pull request as ready for review July 21, 2026 05:58

github-actions Bot added the stale This issue is like stale bread. label Aug 2, 2026

matifali requested a review from dylanhuff-at-coder August 2, 2026 20:01

matifali removed the stale This issue is like stale bread. label Aug 2, 2026

Merge branch 'main' into rowan/multiline_secrets

2e68731

dylanhuff-at-coder reviewed Aug 3, 2026

View reviewed changes

dylanhuff-at-coder approved these changes Aug 3, 2026

View reviewed changes

jakehwll reviewed Aug 3, 2026

View reviewed changes

jakehwll approved these changes Aug 3, 2026

View reviewed changes

dylanhuff-at-coder merged commit f44e8c1 into main Aug 3, 2026
26 checks passed

dylanhuff-at-coder deleted the rowan/multiline_secrets branch August 3, 2026 18:52

dylanhuff-at-coder added the cherry-pick label Aug 3, 2026

github-actions Bot mentioned this pull request Aug 3, 2026

fix: support adding multiline secrets via the UI (#27253) #27808

Merged

rowansmithau mentioned this pull request Aug 3, 2026

User secrets dashboard cannot create multiline file secrets #27173

Closed

Navigation Menu

Uh oh!

fix: support adding multiline secrets via the UI - #27253

fix: support adding multiline secrets via the UI#27253
dylanhuff-at-coder merged 2 commits into
mainfrom
rowan/multiline_secrets

rowansmithau commented Jul 15, 2026

Uh oh!

matifali commented Aug 2, 2026

Uh oh!

dylanhuff-at-coder Aug 3, 2026

Uh oh!

dylanhuff-at-coder left a comment

Uh oh!

jakehwll Aug 3, 2026

Uh oh!

jakehwll left a comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

rowansmithau commented Jul 15, 2026

Uh oh!

matifali commented Aug 2, 2026

Uh oh!

dylanhuff-at-coder Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

dylanhuff-at-coder left a comment

Choose a reason for hiding this comment

Uh oh!

jakehwll Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

jakehwll left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants