Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(helm/coder): make HTTPS redirect status code configurable #27360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvigilante merged 1 commit into from
Aug 3, 2026
Merged

feat(helm/coder): make HTTPS redirect status code configurable #27360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions helm/coder/templates/httproute.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
{{- if and .Values.coder.httproute.enable .Values.coder.httproute.httpsRedirect.enable (empty .Values.coder.httproute.httpsRedirect.parentRefs) -}}
{{- if and .Values.coder.httproute.enable .Values.coder.httproute.httpsRedirect.enable -}}
{{- if empty .Values.coder.httproute.httpsRedirect.parentRefs -}}
{{- fail "coder.httproute.httpsRedirect.parentRefs is required when coder.httproute.httpsRedirect.enable=true" -}}
{{- end -}}
{{- $httpsRedirectStatusCode := toString .Values.coder.httproute.httpsRedirect.statusCode -}}
{{- if not (regexMatch "^(301|302|303|307|308)$" $httpsRedirectStatusCode) -}}
{{- fail "coder.httproute.httpsRedirect.statusCode must be one of 301, 302, 303, 307, or 308." -}}
{{- end -}}
{{- end -}}

{{- if .Values.coder.httproute.enable }}
---
Expand Down Expand Up @@ -29,6 +35,7 @@ spec:
- {{ . | quote }}
{{- end }}
{{- if .Values.coder.httproute.httpsRedirect.enable }}
{{- $httpsRedirectStatusCode := toString .Values.coder.httproute.httpsRedirect.statusCode }}
---
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
Expand All @@ -48,7 +55,7 @@ spec:
- filters:
- requestRedirect:
scheme: https
statusCode: 308
statusCode: {{ $httpsRedirectStatusCode }}
type: RequestRedirect
matches:
- path:
Expand Down
2 changes: 1 addition & 1 deletion helm/coder/tests/testdata/listenerset_redirect.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ spec:
- filters:
- requestRedirect:
scheme: https
statusCode: 308
statusCode: 301
type: RequestRedirect
matches:
- path:
Expand Down
1 change: 1 addition & 0 deletions helm/coder/tests/testdata/listenerset_redirect.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ coder:
host: coder.example.com
httpsRedirect:
enable: true
statusCode: 301
parentRefs:
- name: fake-gateway
port: 80
Expand Down
2 changes: 1 addition & 1 deletion helm/coder/tests/testdata/listenerset_redirect_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ spec:
- filters:
- requestRedirect:
scheme: https
statusCode: 308
statusCode: 301
type: RequestRedirect
matches:
- path:
Expand Down
3 changes: 3 additions & 0 deletions helm/coder/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,9 @@ coder:
enable: false
# coder.httproute.httpsRedirect.annotations -- The redirect HTTPRoute annotations.
annotations: {}
# coder.httproute.httpsRedirect.statusCode -- The redirect response status code.
# Supported values are 301, 302, 303, 307, and 308.
statusCode: 308
# coder.httproute.httpsRedirect.parentRefs -- the parentRefs to bind the route to
# - kind: ListenerSet
# name: coder
Expand Down
Loading