feat(site/src/pages/AgentsPage): wire chat search box to full-text search #27375
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| // The backend's search-query parser toggles its quoted-state on every `"` and | ||
| // has no backslash-escape handling, so escaping quotes here would produce a | ||
| // query the backend cannot parse. Stripping quotes from structured filter | ||
| // values keeps the resulting `key:"..."` token well-formed for the backend. | ||
| // Bare free text is not sanitized this way so that FTS quoted phrases survive. | ||
| const sanitizeChatSearchValue = (value: string): string => { | ||
| return value.replaceAll('"', ""); | ||
| }; | ||
|
|
@@ -10,9 +11,32 @@ const addDefaultURLScheme = (value: string): string => { | |
| return /^[a-z][a-z\d+\-.]*:\/\//i.test(value) ? value : `https://${value}`; | ||
| }; | ||
|
|
||
| // Bare free text may contain websearch operators (quoted phrases, OR, | ||
| // -negation). Detect a leading/trailing quote pair so those pass through | ||
| // unmodified; everything else gets wrapped in a single quoted phrase. | ||
| const hasWebSearchQuotes = (value: string): boolean => { | ||
| const first = value.indexOf('"'); | ||
| const last = value.lastIndexOf('"'); | ||
| return ( | ||
| first !== -1 && last > first && /\S/.test(value.slice(first + 1, last)) | ||
|
Contributor
There was a problem hiding this comment. P1 [CRF-1]
Verified empirically against
The backend tokenizer (
Contributor
Author
There was a problem hiding this comment. Fixed in the successor PR #27973 (this PR was auto-closed as stale and could not be reopened after the rebase). Dropped the
|
||
| ); | ||
| }; | ||
|
|
||
| // Wrap bare free text in a quoted phrase so multi-word input reaches the | ||
| // backend's FTS filter as a single token. Quotes are stripped first because | ||
| // the backend's query parser has no escape handling for embedded quotes. | ||
| const toSearchPhrase = (terms: string): string => { | ||
| const joined = terms.trim(); | ||
| if (hasWebSearchQuotes(joined)) { | ||
| return joined; | ||
| } | ||
| return `"${sanitizeChatSearchValue(joined)}"`; | ||
| }; | ||
|
|
||
| // Filter keys that may pass through to the backend unchanged. `title` is not | ||
| // listed here because bare text and `title:` filters are merged into a single | ||
| // FTS `search:` filter; see the search-handling branch in | ||
| // normalizeChatSearchInput. | ||
| const passthroughChatSearchFilterKeys = new Set([ | ||
| "archived", | ||
| "diff_url", | ||
|
|
@@ -107,7 +131,7 @@ const normalizePassthroughChatSearchFilter = ({ | |
| /** | ||
| * Normalizes raw search input into a query string the chat search API accepts. | ||
| * | ||
| * Bare text and `title:` filters are merged into a single `search:` FTS | ||
| * filter (the backend rejects a parameter that appears more than once). | ||
| * Recognized `key:value` filters are normalized for backend syntax. | ||
| */ | ||
|
|
@@ -122,26 +146,26 @@ export const normalizeChatSearchInput = ( | |
| const tokens = splitSearchInput(trimmedInput); | ||
| const passthroughFilters: string[] = []; | ||
| const normalizedTokens: string[] = []; | ||
| const searchTerms: string[] = []; | ||
| let hasBareSearchText = false; | ||
|
|
||
| for (const token of tokens) { | ||
| const keyValuePair = getKeyValuePair(token); | ||
| if (!keyValuePair) { | ||
| searchTerms.push(token); | ||
| hasBareSearchText = true; | ||
| continue; | ||
| } | ||
|
|
||
| if (keyValuePair.key === "title") { | ||
| normalizedTokens.push(token); | ||
| searchTerms.push(keyValuePair.value); | ||
| continue; | ||
| } | ||
|
|
||
| if (!passthroughChatSearchFilterKeys.has(keyValuePair.key)) { | ||
| searchTerms.push(token); | ||
| hasBareSearchText = true; | ||
| continue; | ||
| } | ||
|
|
||
|
|
@@ -150,18 +174,20 @@ export const normalizeChatSearchInput = ( | |
| normalizedTokens.push(normalizedFilter); | ||
| } | ||
|
|
||
| // Multiple search values must be merged into a single search filter because | ||
| // the backend's query parser rejects the same key appearing more than once. | ||
| if (searchTerms.length > 1) { | ||
| hasBareSearchText = true; | ||
| } | ||
|
|
||
| if (!hasBareSearchText) { | ||
| return normalizedTokens.join(" "); | ||
| } | ||
|
|
||
| // Free text defaults to the backend's full-text search filter, which | ||
| // matches chat titles, PR titles, and message bodies. | ||
| return [ | ||
| ...passthroughFilters, | ||
| `search:${toSearchPhrase(searchTerms.join(" "))}`, | ||
| ].join(" "); | ||
| }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 [CRF-2] Test asserts an emitted string the backend rejects, codifying the CRF-1 bug as expected behavior. (Netero)
The sibling assertion at :90 (
Fix "auth" middleware->search:Fix "auth" middleware) has the same defect. Both check output shape and never verify backend acceptance, so they stay green while the feature is broken. A regression test for this path should assert against the backend parser's acceptance of the emitted query.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the successor PR #27973 (this PR was auto-closed as stale and could not be reopened after the rebase).
Rewrote both tests to assert the strip-and-wrap behavior that the backend actually accepts:
Fix "auth" middleware->search:"Fix auth middleware"and"fix race" OR deadlock -timeout->search:"fix race OR deadlock -timeout". The emitted outputs were verified against the realsearchquery.Chatsparser to confirm acceptance, addressing the "tests pass green while the feature is broken" concern.