-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: log tailnet tunnels to the connection log #27423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7ee8432
b5436eb
ff1fd2b
91799f6
8c274cb
19b6bb2
de58458
3192030
bb24335
14bf16c
8c22808
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| -- The 'tunnel' enum value is intentionally not removed. Postgres cannot | ||
| -- drop an enum value in place; removing it would require recreating | ||
| -- connection_type and rewriting the connection_logs type column, which | ||
| -- takes an exclusive lock on the table and would have to DELETE all | ||
| -- tunnel rows (audit data) because they cannot exist in the old type. | ||
| -- Leaving the value in place is harmless: old code never queries for it | ||
| -- and renders unknown types without error. This matches the precedent | ||
| -- of other enum-value additions (e.g. 000517, 000531). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ALTER TYPE connection_type ADD VALUE IF NOT EXISTS 'tunnel'; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the proxy path: the skip here is correct by design. Proxy-authenticated coordinates (
RequireAPIKeyOrWorkspaceProxyAuth) are shared proxy↔agent tunnels carrying many users' traffic, and per-user attribution for proxied activity already happens at the app layer (the wsproxy's workspaceapps provider writesworkspace_app/port_forwarding/terminal rows with user identity). Logging them as tunnel rows would just be unattributed noise.That leaves Coder Desktop / the user-scoped tailnet API as the one real attribution gap — is that tracked as a follow-up?
Coder Agents on behalf of @Emyrk.