Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: scope AI budget notifications to least privilege #27433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evgeniy-scherbina merged 1 commit into from
Jul 22, 2026
Merged

refactor: scope AI budget notifications to least privilege #27433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions coderd/aibridgedserver/notifications.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,7 @@ func (s *Server) detectBudgetThresholdCrossings(ctx context.Context, tx database
// notifyBudgetThresholdCrossing enqueues the notification for the user who
// crossed the threshold.
func (s *Server) notifyBudgetThresholdCrossing(ctx context.Context, crossing budgetThresholdCrossing) error {
//nolint:gocritic // The interception context is scoped to AI Bridge; reading the group and enqueuing need system access.
sysCtx := dbauthz.AsSystemRestricted(ctx)

group, err := s.store.GetGroupByID(sysCtx, crossing.groupID)
group, err := s.store.GetGroupByID(ctx, crossing.groupID)
if err != nil {
return xerrors.Errorf("look up group %q: %w", crossing.groupID, err)
}
Expand All @@ -118,7 +115,8 @@ func (s *Server) notifyBudgetThresholdCrossing(ctx context.Context, crossing bud
"group_name": group.Name,
}

if _, err := s.notifEnqueuer.EnqueueWithData(sysCtx, crossing.userID, crossing.template,
//nolint:gocritic // Enqueuing notifications requires the notifier actor.
if _, err := s.notifEnqueuer.EnqueueWithData(dbauthz.AsNotifier(ctx), crossing.userID, crossing.template,
labels, nil, budgetNotificationsCreatedBy,
crossing.groupID,
); err != nil {
Expand Down
1 change: 1 addition & 0 deletions coderd/database/dbauthz/dbauthz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,6 +696,7 @@ var (
rbac.ResourceAiModelPrice.Type: {policy.ActionRead, policy.ActionUpdate}, // Read: per-interception cost lookup. Update: startup price seeder.
rbac.ResourceAiSeat.Type: {policy.ActionCreate}, // Required for UpsertAISeatState.
rbac.ResourceAIProvider.Type: {policy.ActionRead}, // Required to load the provider snapshot (and per-provider keys) at startup.
rbac.ResourceGroup.Type: {policy.ActionRead}, // Required to read the effective group.
}),
User: []rbac.Permission{},
ByOrgID: map[string]rbac.OrgPermissions{},
Expand Down
Loading