Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site/src/pages/TemplateBuilder): show all step content without inner scroll #27437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyruppel merged 1 commit into from
Jul 22, 2026
Merged

fix(site/src/pages/TemplateBuilder): show all step content without inner scroll #27437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions site/src/pages/TemplateBuilder/BaseInfraSelectStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ export const BaseInfraSelectStep: FC<BaseInfraSelectStepProps> = ({
Select your infrastructure foundation.
</TemplateBuilderSubtitle>

{/* 420px accounts for navbar, page header, card padding, tab bar, and nav controls */}
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-3 gap-4 max-h-[calc(100vh-420px)] overflow-y-auto">
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-3 gap-4">
{bases.map((base) => (
<TemplateCard
key={base.id}
Expand Down
49 changes: 23 additions & 26 deletions site/src/pages/TemplateBuilder/BaseTemplateParametersStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,32 +123,29 @@ export const BaseTemplateParametersStep: FC<
Your base template requires customizations.
</TemplateBuilderSubtitle>

{/* 340px accounts for navbar, page header, card padding, and nav controls */}
<div className="max-h-[calc(100vh-340px)] overflow-y-auto">
<TemplateConfiguration
name={base?.name ?? "Base Template"}
description={base?.description ?? ""}
iconUrl={base?.icon}
detailsUrl={detailsUrl(baseId)}
fields={fields}
>
{prerequisites && (
<div className="mt-6">
<MemoizedMarkdown
className={cn(
"text-sm font-normal",
"[&_h2]:mt-6 [&_h2]:text-base [&_h2]:font-semibold",
"[&_h3]:mt-2 [&_h3]:mb-1 [&_h3]:text-sm [&_h3]:font-semibold",
"[&_p]:mb-3 [&_p]:text-content-secondary",
"[&_a]:font-normal",
)}
>
{prerequisites}
</MemoizedMarkdown>
</div>
)}
</TemplateConfiguration>
</div>
<TemplateConfiguration
name={base?.name ?? "Base Template"}
description={base?.description ?? ""}
iconUrl={base?.icon}
detailsUrl={detailsUrl(baseId)}
fields={fields}
>
{prerequisites && (
<div className="mt-6">
<MemoizedMarkdown
className={cn(
"text-sm font-normal",
"[&_h2]:mt-6 [&_h2]:text-base [&_h2]:font-semibold",
"[&_h3]:mt-2 [&_h3]:mb-1 [&_h3]:text-sm [&_h3]:font-semibold",
"[&_p]:mb-3 [&_p]:text-content-secondary",
"[&_a]:font-normal",
)}
>
{prerequisites}
</MemoizedMarkdown>
</div>
)}
</TemplateConfiguration>
</>
);
};
3 changes: 1 addition & 2 deletions site/src/pages/TemplateBuilder/ModuleSelectStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,7 @@ export const ModuleSelectStep: FC<ModuleSelectStepProps> = ({
</TabsList>
</Tabs>

{/* 420px accounts for navbar, page header, card padding, search, tabs, and nav controls */}
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-3 gap-4 max-h-[calc(100vh-420px)] overflow-y-auto">
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-3 gap-4">
{visibleModules.length ? (
visibleModules.map((m) => (
<ModuleCard
Expand Down
3 changes: 1 addition & 2 deletions site/src/pages/TemplateBuilder/ModuleSettingsStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,7 @@ export const ModuleSettingsStep: FC<ModuleSettingsStepProps> = ({
Set values for module variables.
</TemplateBuilderSubtitle>

{/* 340px accounts for navbar, page header, card padding, and nav controls */}
<div className="flex flex-col gap-6 max-h-[calc(100vh-340px)] overflow-y-auto">
<div className="flex flex-col gap-6">
{selectedModules.map((mod) => {
const configurableVars = mod.variables.filter((v) => !v.sensitive);
const sensitiveVars = mod.variables.filter((v) => v.sensitive);
Expand Down
Loading