Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: clarify wording of install.sh --dry-run output #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2022
Merged

fix: clarify wording of install.sh --dry-run output #2751

merged 1 commit into from
Jun 30, 2022

Conversation

dwahler
Copy link
Contributor

@dwahler dwahler commented Jun 30, 2022

This PR updates the output of install.sh --dry-run to add this message at the top:

Running with --dry-run; the following are the commands that would be run if this were a real installation:

and also replaces the "installation successful" message with:

Dry-run complete.

To install Coder, re-run this script without the --dry-run flag.

in order to not make it seem like we actually made changes to the machine.

Fixes #2356

@dwahler dwahler requested a review from bpmct June 30, 2022 15:54
@bpmct
Copy link
Member

bpmct commented Jun 30, 2022

Awesome, thanks for doing this!

@dwahler dwahler merged commit 29be359 into main Jun 30, 2022
@dwahler dwahler deleted the david/2356-dryrun-messages branch June 30, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpmct bpmct bpmct approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install.sh --dry-run prints misleading output
2 participants
@dwahler @bpmct