refactor(site): remove Emotion from IconField - #27618
Closed
aqandrew wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
closing in favor of #27719 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO need to redefine styles again because vars like
--rgb-colorexpect a list of numbers, not an actual color--this is causing top bar hover color styles to breakmoves
IconFieldcomponent styles from @emotion/react to index.cssAlso fixes a bug where the AI settings page's
IconPickerField's emoji picker styles were dark regardless of the user's light/dark theme preferencebefore
after