fix(site/src/pages/UserSettingsPage/SecretsPage): prevent Add secret dialog overflow - #27649
Merged
dylanhuff-at-coder merged 1 commit intoJul 30, 2026
Merged
Conversation
…dialog overflow The 'or add individually' divider used two full-width Separators in a flex row. Separator is styled w-full shrink-0, so each one took the full dialog width and the row overflowed horizontally. Give each separator flex-1 so they split the space around the label instead.
dylanhuff-at-coder
marked this pull request as ready for review
July 30, 2026 17:21
aslilac
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes PLAT-408
Fixes a horizontal overflow in the Add secret dialog introduced by #26725. The "or add individually" divider renders two
Separatorcomponents in aflex items-centerrow.Separatoris styledw-full shrink-0, so each separator took the full dialog width and refused to shrink, making the row roughly twice the dialog width and forcing a horizontal scrollbar.Adding
flex-1to both separators setsflex-basis: 0%, which overridesw-fullfor main-axis sizing, so the two separators split the space around the label instead of overflowing.Verified with a local dev instance and a headless browser: the dialog renders at its normal width with no horizontal scroll (
document.body.scrollWidthno longer exceeds the viewport).Decision log
site/src/components/Separator/Separator.tsx: the base class list isbg-border shrink-0 ... data-[orientation=horizontal]:w-full ..., so two horizontal separators in one flex row each demand 100% of the container width.flex-1on the call site over changing the sharedSeparatorcomponent, since the component matches the upstream shadcn/ui implementation and other usages rely on the full-width default.flex-1works regardless of theshrink-0base class because it setsflex-basis: 0%; the separators grow equally from zero, so shrink behavior is irrelevant.