Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(helm/ai-gateway): render service nodePort with an explicit if guard #27682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawbana merged 1 commit into from
Jul 30, 2026
Merged

fix(helm/ai-gateway): render service nodePort with an explicit if guard #27682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm/ai-gateway/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
port: {{ .Values.service.port }}
targetPort: http
protocol: TCP
{{- with .Values.service.nodePort }}
nodePort: {{ . }}
{{- if .Values.service.nodePort }}
nodePort: {{ .Values.service.nodePort }}
{{- end }}
{{- end }}
87 changes: 87 additions & 0 deletions helm/ai-gateway/tests/chart_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,85 @@ var testCases = []testCase{
{
name: "default_values",
fixture: "default_values",
// The fixture enables every optional resource, so this case covers
// rendering of all templates with the minimum required values.
apiVersions: []string{"gateway.networking.k8s.io/v1/HTTPRoute"},
mustNotContain: []string{
// Service fields that only render when their value is set.
"nodePort:",
"loadBalancerClass:",
"loadBalancerIP:",
// externalTrafficPolicy only applies to NodePort and LoadBalancer.
"externalTrafficPolicy:",
// Ingress and HTTPRoute render with required fields only.
"ingressClassName:",
"hostnames:",
// No secret is configured, so nothing mounts a Secret or switches
// the probes and listener to TLS.
"secretName:",
"CODER_AI_GATEWAY_KEY_FILE",
"CODER_AI_GATEWAY_TLS_CERT_FILE",
"CODER_CLIENT_TLS_CA_FILE",
"CODER_CLIENT_TLS_CERT_FILE",
"scheme: HTTPS",
// Opt-in workload settings.
"startupProbe:",
"envFrom:",
"imagePullSecrets:",
"priorityClassName:",
"kind: ConfigMap",
},
},
{
name: "networking",
fixture: "networking",
namespace: "ai-gateway-test",
apiVersions: []string{"gateway.networking.k8s.io/v1/HTTPRoute"},
mustNotContain: []string{
// The Service is a LoadBalancer without an explicit nodePort, so
// Kubernetes allocates the port.
"nodePort:",
"loadBalancerIP:",
// Only the Gateway key Secret is configured.
"ai-gateway-listener",
"coder-client-ca",
"coder-client-tls",
"scheme: HTTPS",
"startupProbe:",
"envFrom:",
},
},
{
name: "custom",
fixture: "custom",
namespace: "ai-gateway-test",
mustNotContain: []string{
// coder.serviceAccount.disableCreate is true, so the chart uses the
// existing account instead of creating one.
"kind: ServiceAccount",
// Only the default ClusterIP Service renders.
"kind: Ingress",
"kind: HTTPRoute",
"nodePort:",
"loadBalancerClass:",
"loadBalancerIP:",
"externalTrafficPolicy:",
},
},
{
name: "nodeport",
fixture: "nodeport",
mustNotContain: []string{
// LoadBalancer-only fields stay absent for a NodePort Service.
"loadBalancerClass:",
"loadBalancerIP:",
"kind: Ingress",
"kind: HTTPRoute",
"ai-gateway-listener",
"coder-client-ca",
"coder-client-tls",
"scheme: HTTPS",
},
},
{
name: "missing_key_field",
Expand All @@ -54,6 +118,20 @@ var testCases = []testCase{
{
name: "listener_tls_with_ingress",
fixture: "listener_tls_with_ingress",
mustNotContain: []string{
// Listener TLS does not imply client TLS to coderd.
"coder-client-ca",
"coder-client-tls",
"CODER_CLIENT_TLS_CA_FILE",
"CODER_CLIENT_TLS_CERT_FILE",
// The Ingress renders with required fields only.
"ingressClassName:",
"kind: HTTPRoute",
"nodePort:",
"loadBalancerClass:",
"loadBalancerIP:",
"externalTrafficPolicy:",
},
},
{
name: "partial_client_tls",
Expand Down Expand Up @@ -104,6 +182,12 @@ type testCase struct {
namespace string
expectedError string
apiVersions []string
// mustNotContain holds substrings that must be absent from the rendered
// output. Golden files are rewritten wholesale by TestUpdateGoldenFiles,
// so absence assertions live here to keep an unintended field from being
// baked into the golden file. Each entry names an optional field or
// resource that the fixture leaves unset.
mustNotContain []string
}

func (tc testCase) valuesFilePath() string {
Expand Down Expand Up @@ -143,6 +227,9 @@ func TestRenderChart(t *testing.T) {
return
}
require.NoError(t, err, output)
for _, absent := range tc.mustNotContain {
require.NotContains(t, output, absent)
}
golden, err := os.ReadFile(tc.goldenFilePath())
require.NoError(t, err)
golden = bytes.ReplaceAll(golden, []byte("\r"), nil)
Expand Down
51 changes: 51 additions & 0 deletions helm/ai-gateway/tests/testdata/default_values.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,3 +137,54 @@ spec:
serviceAccountName: coder-ai-gateway
terminationGracePeriodSeconds: 330
volumes: []
---
# Source: coder-ai-gateway/templates/ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: coder-ai-gateway
namespace: default
labels:
helm.sh/chart: coder-ai-gateway-0.1.0
app.kubernetes.io/name: coder-ai-gateway
app.kubernetes.io/instance: ai-gateway
app.kubernetes.io/part-of: coder-ai-gateway
app.kubernetes.io/version: "0.1.0"
app.kubernetes.io/managed-by: Helm
spec:
rules:
- host: "ai.example.com"
http:
paths:
- path: /
pathType: Prefix
backend:
service:
name: coder-ai-gateway
port:
number: 80
---
# Source: coder-ai-gateway/templates/httproute.yaml
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
name: coder-ai-gateway
namespace: default
labels:
helm.sh/chart: coder-ai-gateway-0.1.0
app.kubernetes.io/name: coder-ai-gateway
app.kubernetes.io/instance: ai-gateway
app.kubernetes.io/part-of: coder-ai-gateway
app.kubernetes.io/version: "0.1.0"
app.kubernetes.io/managed-by: Helm
spec:
parentRefs:
- name: shared-gateway
rules:
- matches:
- path:
type: PathPrefix
value: /
backendRefs:
- name: coder-ai-gateway
port: 80
10 changes: 10 additions & 0 deletions helm/ai-gateway/tests/testdata/default_values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,13 @@ coder:
name: ai-gateway-key
key: key
aigateway: {}
# Enable every optional resource with only the values each one requires, so
# the golden file covers rendering of all templates without opting into
# non-default settings such as service.nodePort.
ingress:
enable: true
host: ai.example.com
httproute:
enable: true
parentRefs:
- name: shared-gateway
Loading