Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site/src/pages/AgentsPage/components/ChatElements/tools): delete unreachable WaitForExternalAuth tool code #27684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielleMaywood merged 1 commit into from
Jul 30, 2026
Merged

fix(site/src/pages/AgentsPage/components/ChatElements/tools): delete unreachable WaitForExternalAuth tool code #27684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 0 additions & 80 deletions site/src/pages/AgentsPage/components/ChatElements/tools/ExecuteTool.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import {
CheckIcon,
CircleAlertIcon,
ExternalLinkIcon,
LayersIcon,
LoaderIcon,
OctagonXIcon,
} from "lucide-react";
import type React from "react";
Expand Down Expand Up @@ -283,81 +281,3 @@ export const ExecuteAuthRequiredTool: React.FC<{
</div>
);
};
Comment thread
DanielleMaywood marked this conversation as resolved.

export const WaitForExternalAuthTool: React.FC<{
providerLabel: string;
status: ToolStatus;
authenticated: boolean;
timedOut: boolean;
isError: boolean;
errorMessage?: string;
}> = ({
providerLabel,
status,
authenticated,
timedOut,
isError,
errorMessage,
}) => {
const isRunning = status === "running";
let label = `Waiting for ${providerLabel} authentication...`;
let statusIcon: React.ReactNode = isRunning ? (
<LoaderIcon
aria-label="Authentication in progress"
role="img"
className="size-3.5 shrink-0 animate-spin text-content-link motion-reduce:animate-none"
/>
) : null;
if (isError) {
label =
errorMessage ||
`Failed while waiting for ${providerLabel} authentication`;
statusIcon = (
<OctagonXIcon
aria-label="Authentication failed"
role="img"
className="size-3.5 shrink-0 text-content-destructive"
/>
);
} else if (timedOut) {
label = `Timed out waiting for ${providerLabel} authentication`;
statusIcon = (
<CircleAlertIcon
aria-label="Authentication timed out"
role="img"
className="size-3.5 shrink-0 text-content-warning"
/>
);
} else if (authenticated && !isRunning) {
label = `Authenticated with ${providerLabel}`;
statusIcon = (
<CheckIcon
aria-label="Authentication completed"
role="img"
className="size-3.5 shrink-0 text-content-success"
/>
);
}

return (
<ToolCall.Root
className="w-full overflow-hidden rounded-md border border-solid border-border-default bg-surface-primary px-3 py-2"
status={status}
isError={isError}
errorMessage={
errorMessage ||
`Failed while waiting for ${providerLabel} authentication`
}
hasContent={false}
>
<ToolCall.HeaderLayout>
<ToolCall.HeaderButton className="min-w-0 flex-1 font-normal text-content-secondary">
<ToolCall.LeadingIcon>{statusIcon}</ToolCall.LeadingIcon>
<ToolCall.Label className="text-content-primary">
{label}
</ToolCall.Label>
</ToolCall.HeaderButton>
</ToolCall.HeaderLayout>
</ToolCall.Root>
);
};
67 changes: 0 additions & 67 deletions site/src/pages/AgentsPage/components/ChatElements/tools/Tool.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,6 @@ const allToolShowcaseItems: ToolShowcaseItem[] = [
args: { process_id: "storybook-process", signal: "terminate" },
result: { success: true },
},
{
name: "wait_for_external_auth",
args: { provider: "github" },
result: { provider_display_name: "GitHub", authenticated: true },
},
{
name: "read_file",
args: { path: "site/src/pages/AgentsPage/AgentChatPage.tsx" },
Expand Down Expand Up @@ -601,68 +596,6 @@ export const ExecuteAuthRequired: Story = {
},
};

// ---------------------------------------------------------------------------
// WaitForExternalAuth stories
// ---------------------------------------------------------------------------

export const WaitForExternalAuthRunning: Story = {
args: {
name: "wait_for_external_auth",
status: "running",
result: {
provider_display_name: "GitHub",
authenticated: false,
},
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
expect(
canvas.getByText("Waiting for GitHub authentication..."),
).toBeInTheDocument();
expect(
canvas.getByRole("img", { name: "Authentication in progress" }),
).toBeVisible();
},
};

export const WaitForExternalAuthAuthenticated: Story = {
args: {
name: "wait_for_external_auth",
status: "completed",
result: {
provider_display_name: "GitHub",
authenticated: true,
},
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
expect(canvas.getByText("Authenticated with GitHub")).toBeInTheDocument();
},
};

export const WaitForExternalAuthTimedOut: Story = {
args: {
name: "wait_for_external_auth",
status: "completed",
result: {
provider_display_name: "GitHub",
timed_out: true,
},
},
};

export const WaitForExternalAuthError: Story = {
args: {
name: "wait_for_external_auth",
status: "error",
isError: true,
result: {
provider_display_name: "GitHub",
error: "Authentication failed: token exchange was rejected.",
},
},
};

// ---------------------------------------------------------------------------
// Subagent stories
// ---------------------------------------------------------------------------
Expand Down
30 changes: 0 additions & 30 deletions site/src/pages/AgentsPage/components/ChatElements/tools/Tool.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import { EditFilesTool } from "./EditFilesTool";
import {
ExecuteAuthRequiredTool,
ExecuteTool as ExecuteToolComponent,
WaitForExternalAuthTool,
} from "./ExecuteTool";
import { ListAgentsTool } from "./ListAgentsTool";
import { ListTemplatesTool } from "./ListTemplatesTool";
Expand Down Expand Up @@ -59,7 +58,6 @@ import {
parseServerEditDiffText,
parseServerEditResults,
type ToolStatus,
toProviderLabel,
} from "./utils";

import { WriteFileTool } from "./WriteFileTool";
Expand Down Expand Up @@ -285,33 +283,6 @@ const ProcessOutputRenderer: FC<ToolRendererProps> = ({
);
};

const WaitForExternalAuthRenderer: FC<ToolRendererProps> = ({
status,
result,
isError,
}) => {
const rec = asRecord(result);
const providerLabel = toProviderLabel(
rec ? asString(rec.provider_display_name).trim() : "",
rec ? asString(rec.provider_id).trim() : "",
rec ? asString(rec.provider_type).trim() : "",
);
const authenticated = rec ? Boolean(rec.authenticated) : false;
const timedOut = rec ? Boolean(rec.timed_out) : false;
const errorMessage = rec ? asString(rec.error || rec.message) : "";

return (
<WaitForExternalAuthTool
providerLabel={providerLabel}
status={status}
authenticated={authenticated}
timedOut={timedOut}
isError={isError}
errorMessage={errorMessage || undefined}
/>
);
};

const ReadFileRenderer: FC<ToolRendererProps> = ({
status,
args,
Expand Down Expand Up @@ -1066,7 +1037,6 @@ const toolRenderers: Record<string, FC<ToolRendererProps>> = {
execute: ExecuteRenderer,
process_output: ProcessOutputRenderer,
process_signal: ProcessSignalRenderer,
wait_for_external_auth: WaitForExternalAuthRenderer,
read_file: ReadFileRenderer,
Comment thread
DanielleMaywood marked this conversation as resolved.
Comment thread
DanielleMaywood marked this conversation as resolved.
write_file: WriteFileRenderer,
edit_files: EditFilesRenderer,
Expand Down
3 changes: 0 additions & 3 deletions site/src/pages/AgentsPage/components/ChatElements/tools/ToolIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {
FilePenLineIcon,
FileTextIcon,
LightbulbIcon,
LogInIcon,
MonitorIcon,
PowerIcon,
RouteIcon,
Expand Down Expand Up @@ -80,8 +79,6 @@ export const ToolIcon: React.FC<{
case "process_list":
case "process_signal":
return <TerminalIcon className={base} />;
case "wait_for_external_auth":
return <LogInIcon className={base} />;
case "read_file":
case "read_skill":
case "read_skill_file":
Expand Down
Loading