Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(agent): detect IPv6-bound listening ports #27765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpmct merged 3 commits into from
Aug 3, 2026
Merged

fix(agent): detect IPv6-bound listening ports #27765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4f92fb
fix(agent): detect IPv6-bound listening ports
bpmct Jul 31, 2026
296a0e2
Merge branch 'main' into fix-ipv6-listening-ports
bpmct Aug 2, 2026
474bece
test(agent): hoist TCPAddr cast in IPv6 ports test
bpmct Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions agent/ports_supported.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,29 @@ func (lp *osListeningPortsGetter) GetListeningPorts() ([]codersdk.WorkspaceAgent
return ports, nil
}

tabs, err := netstat.TCPSocks(func(s *netstat.SockTabEntry) bool {
acceptListening := func(s *netstat.SockTabEntry) bool {
return s.State == netstat.Listen
})
}

tabs, err := netstat.TCPSocks(acceptListening)
if err != nil {
return nil, xerrors.Errorf("scan listening ports: %w", err)
}

// Include IPv6 listeners too. Many dev servers (e.g. Next.js, Node's
// default http.Server) bind to the IPv6 wildcard address "::", which is
// a dual-stack socket that also accepts IPv4 connections, but only shows
// up in the IPv6 socket table (/proc/net/tcp6), not /proc/net/tcp.
//
// The IPv6 scan fails on systems with IPv6 disabled (e.g. missing
// /proc/net/tcp6 on Linux). Fall back to the IPv4 results instead of
// failing the whole scan, otherwise the ports UI breaks entirely on
// such systems.
tabs6, err := netstat.TCP6Socks(acceptListening)
if err == nil {
tabs = append(tabs, tabs6...)
}
Comment thread
jeremyruppel marked this conversation as resolved.

seen := make(map[uint16]struct{}, len(tabs))
ports := []codersdk.WorkspaceAgentListeningPort{}
for _, tab := range tabs {
Expand Down
30 changes: 30 additions & 0 deletions agent/ports_supported_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,33 @@ func TestOSListeningPortsGetter(t *testing.T) {
// note that it's unsafe to try to assert that a port does not exist in the response
// because the OS may reallocate the port very quickly.
}

func TestOSListeningPortsGetter_IPv6(t *testing.T) {
t.Parallel()

uut := &osListeningPortsGetter{
cacheDuration: 1 * time.Hour,
}

// Many dev servers (e.g. Next.js) bind to the IPv6 wildcard address,
// which is dual-stack and only shows up in the IPv6 socket table.
l, err := net.Listen("tcp", "[::]:0")
Comment thread
jeremyruppel marked this conversation as resolved.
if err != nil {
t.Skipf("unable to listen on IPv6 wildcard address: %s", err)
}
defer l.Close()

// #nosec G115 - Safe conversion as TCP port numbers are within uint16 range (0-65535)
want := uint16(l.Addr().(*net.TCPAddr).Port)

ports, err := uut.GetListeningPorts()
require.NoError(t, err)
found := false
for _, port := range ports {
if port.Port == want {
found = true
break
}
}
require.True(t, found, "port %d not found in %v", want, ports)
}
Loading