P3 [CRF-3] The comment claims the rejected PATCH left the stored provider untouched, but no assertion can show that; the check passes either way. (Netero)

The rejected PATCH (line 649-656) sets Region: "us-west-2". The following accepted PATCH sets Region: "us-west-2" as well, and the assertions run only after it. If a future change let a validation failure partially apply, this test would still pass. Same for the model fields: they are only ever read after the successful PATCH.

A comment asserting coverage that does not exist is worse than no comment: the next reader trusts it and does not add the assertion. Either read the provider back between the rejected and the accepted PATCH and assert Region == "us-east-2" with both models at their created values, or drop the second clause of the comment.

🤖

Note [CRF-5] Existing rows that already carry the broken shape are unaffected by this PR. (Netero)

Validation only guards new writes. Rows seeded from env, inserted by dbgen, or promoted by BackfillBedrockProviderType [...] keep 404ing with a WARN until an operator re-saves them through the UI, which now supplies both models. Nothing in the diff detects or reports them.

Recorded, not a request to change this PR. Whether AIGOV-564 is closed for deployments already in the broken state, and whether that needs a backfill or a surfaced provider-build status, is a human call. Say which one you intend, here or in the issue.

🤖

P3 [CRF-2] The models gate fires on any non-nil bedrock blob, including one that is not a Bedrock provider at all, so a bearer-token Anthropic create carrying settings.bedrock: {} is now rejected with a Bedrock model error. (Netero)

Every other Bedrock gate in this area first asks whether the blob is a Bedrock provider: create's own type=bedrock requires bedrock settings uses IsConfigured(), bedrockConfig returns nil for an unconfigured blob [...] validateAIProviderBedrockModels skips that question.

create {type: anthropic, api_keys: [sk-test], settings.bedrock: {}}
  -> settings.model: model is required for the invoke-model protocol
     settings.small_fast_model: small_fast_model is required for the invoke-model protocol

The error names fields the caller has no reason to set. There is a second consequence on the PATCH path: req.Validate() runs before the handler's type check, so a PATCH placing bedrock settings on an openai provider without models now returns "model is required for the invoke-model protocol" instead of Bedrock settings are only valid for type=anthropic or type=bedrock. That is what forced the fixture edit at coderd/ai_providers_test.go:588-598; the existing subtest now only reaches the type check because it supplies models.

One correction to the reviewer's proposed fix. IsBedrockConfigured(baseURL, b) is baseURL != "" || b.IsConfigured(), and base URL is required on every provider, so that gate would fire for every request carrying a bedrock blob, which is the current behavior. The runtime's own "is this Bedrock" test is IsConfigured() on the settings blob alone (cli/aibridged.go:341-348, whose comment states base URL cannot serve as a detection signal), and a bedrock-typed provider with IsConfigured() == false is already rejected on create and refused at build time. Gating on IsConfigured() is what makes the API agree with the runtime.

Not reachable from the UI: providerFormApiMap.ts only emits a bedrock blob when type === "bedrock". API clients can hit it.

🤖

P3 [CRF-4] The PR deletes the rationale for why Model and SmallFastModel are excluded from IsConfigured(), and the rationale is still true. (Netero)

Those defaults still exist: codersdk/deployment.go:1992 (global.anthropic.claude-sonnet-4-5-20250929-v1:0) and :2002 (global.anthropic.claude-haiku-4-5-20251001-v1:0) [...] Three other sites still repeat the same reason as a secondhand claim: cli/server.go:3404-3407, coderd/ai_providers_migrate.go:219-220, and this file's own surviving "have no defaults" sentence.

the reason now lives everywhere except the definition it constrains, so the next reader who wants a stronger Bedrock detection signal sees only "region and credentials have no defaults" and no statement that adding Model would misfire on every deployment running the defaults.

Confirmed both default declarations are still present at those lines. This PR makes the models required at the API, which is exactly the change that invites a reader to also add them to IsConfigured(), so this is the worst moment to remove the sentence explaining why that breaks. Restore it.

🤖