Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(docs/.style/style-guide): fix self-violations found by audit - #27855

Merged
nickvigilante merged 1 commit into
mainfrom
style-guide-self-audit
Aug 18, 2026
Merged

docs(docs/.style/style-guide): fix self-violations found by audit#27855
nickvigilante merged 1 commit into
mainfrom
style-guide-self-audit

Conversation

@nickvigilante

@nickvigilante nickvigilante commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Builds on #27849 and #27852 (both merged).

Runs every style guide page through the guide's own rules, including the STE-derived rules from #27852, and fixes the violations in the guide's prose and Do examples. Don't examples keep their intentional violations. Three parallel audit passes produced roughly 120 findings; this PR applies the accepted ones.

Objective defects fixed: an unbalanced quotation mark on the audience page, a stale "in this PR" reference in the README, a console Do example whose command and output had been collapsed onto one line, inline > [!NOTE] markers that GitHub renders as literal text instead of callouts, "a onClick", and two stale Vale rule references. Two Do examples modeled banned or wrong prose: the audience page's example contained the exact *Audience: ...* metadata line the same page bans, and a word-choice example had Coder running its own login command.

Rule-adherence fixes: US-quotation comma/period placement throughout, banned idioms and figurative language ("wall of commas", "silently rots", "when in doubt", "stretch goal", "bleeding-edge", the Churchill "put up with" example), simplicity words and vague qualifiers ("easy", "straightforward", "typically", "almost always", "often"), directional "above", framing paragraphs under bare headings, run-in bold leads split to one sentence per source line, prose semicolons split into sentences, 6-item prose enumerations reduced, and end-of-page "Related" sections renamed to Learn more per the guide's own heading rule.

One policy call for docs-team review: the digits-everywhere rule now scopes out numbers that describe language itself ("a contraction joins exactly two words") and one as a determiner or pronoun. The alternative was rewriting every determiner as a digit ("give each paragraph 1 topic"), which makes the prose worse. With the scoped rule, the remaining real counts were converted to digits.

Deliberately not changed: "lands"/"land" as release vocabulary, attributed claims inside the Latin-abbreviations `` block, persona-sketch color on the audience page (writer-facing planning vocabulary), and the "What's a workspace" heading example.

Linear: DOCS-650


This PR was created with AI assistance (Coder Agents).

Base automatically changed from style-guide-ste-adoptions to main August 6, 2026 14:17
Run every style guide page through the guide's own rules, including
the STE-derived rules added in the previous commit, and fix the
violations in the guide's prose and Do examples. Don't examples keep
their intentional violations. Highlights:

- Objective defects: an unbalanced quotation mark, a stale "this PR"
  reference, a mangled console Do example, inline "[!NOTE]" markers
  that GitHub renders as literal text, "a onClick", and stale Vale
  rule references (write-good.Reading, Google.Ordinal).
- A Do example on the audience page used the exact metadata line the
  same page bans; a Do example on the word-choice page had Coder
  running its own login command.
- US-style quotation: commas and periods moved inside closing quotes
  throughout the guide's own prose.
- Banned vocabulary in guide prose: navigational directionality
  ("above"), idioms ("wall of", "silently rots", "when in doubt",
  "stretch goal", "bleeding-edge", "put up with"), simplicity words
  ("easy", "straightforward", "clearly"), and vague qualifiers
  ("typically", "almost always", "often", "rarely").
- Structure: framing paragraphs under bare headings, one sentence per
  source line for run-in bold leads and split example sentences,
  prose semicolons split into sentences, 6-item prose enumerations
  reduced or split, and long sentences brought under the budget.
- Heading consistency: end-of-page "Related" sections renamed to
  "Learn more" to match the guide's own heading rule.
- Policy clarification, flagged for docs-team review: the
  digits-everywhere rule now scopes out numbers that describe
  language itself and "one" as a determiner or pronoun, and the
  remaining prose converts real counts to digits.

Assisted-by: AI
@nickvigilante
nickvigilante force-pushed the style-guide-self-audit branch from 79a55fd to 6c56017 Compare August 14, 2026 17:15
@nickvigilante
nickvigilante marked this pull request as ready for review August 14, 2026 17:18
@nickvigilante
nickvigilante requested a review from matifali August 14, 2026 17:18
@nickvigilante
nickvigilante merged commit 0db25ca into main Aug 18, 2026
38 checks passed
@nickvigilante
nickvigilante deleted the style-guide-self-audit branch August 18, 2026 15:14
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants