Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: show no budget instead of unlimited for empty group AI budget - #27993

Merged
tracyjohnsonux merged 14 commits into
mainfrom
fix/group-ai-budget-no-budget
Aug 19, 2026
Merged

fix: show no budget instead of unlimited for empty group AI budget#27993
tracyjohnsonux merged 14 commits into
mainfrom
fix/group-ai-budget-no-budget

Conversation

@tracyjohnsonux

@tracyjohnsonux tracyjohnsonux commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

An empty per-member AI budget on the group settings page previously displayed "unlimited budget" with a "Members in this group have no spending cap." alert. Unlimited spend only applies when the everyone group is the sole group, so this messaging was misleading everywhere else.

Changes

  • Empty budget now shows "This group has no budget set. View docs" with no info alert. "View docs" links to Effective group resolution using the versioned docs() helper.
  • Removed the "Members in this group have no spending cap." alert entirely.
  • Input placeholder changed from unlimited to no budget.
  • Updated the AIBudgetUncapped story expectations to match.

Unchanged

  • Entering an explicit $0 still shows the "A $0 limit disables AI access for this group." alert, as before.
  • Saving with an empty field still sends null to the budget API; backend semantics are untouched.

Story tests pass: pnpm test:storybook src/pages/GroupsPage/GroupSettingsPageView.stories.tsx (7/7).


This PR was generated by Coder Agents on behalf of @tracyjohnsonux.

@coderagents

coderagents Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Documentation Check

Updates Needed

  • docs/ai-coder/ai-gateway/cost-controls.md - Updated the "Group budget" section to "An empty field means no budget is set. The field displays no budget.", matching the new UI placeholder/label. Addressed.
  • docs/ai-coder/ai-gateway/cost-controls.md - Empty-budget alert ("Members without a budget from another group won't have AI access.") contradicted the documented "unlimited spend" enforcement behavior. (resolved in 79d1319: the message was reworded to "Members will fall back to another group's limit, or if no budgets have been set, they will have no spend limit.", and the $0 alert now clarifies it blocks access only for members not covered by another group's budget. Both now match the "Effective group resolution" and "How enforcement works" sections, so no docs change is needed.)

Automated review via Coder Agents

@tracyjohnsonux

tracyjohnsonux commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author
image

Comment thread site/src/pages/GroupsPage/GroupSettingsPageView.tsx Outdated
Comment thread site/src/pages/GroupsPage/GroupSettingsPageView.tsx Outdated
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

Copy link
Copy Markdown
Contributor Author

Note, this PR doesn't address any doc changes. That is being tracked elsewhere.

Comment thread site/src/pages/GroupsPage/GroupSettingsPageView.tsx
@tracyjohnsonux tracyjohnsonux changed the title fix(site/src/pages/GroupsPage): show no budget instead of unlimited for empty AI budget fix: show no budget instead of unlimited for empty group AI budget Aug 18, 2026

@ssncferreira ssncferreira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@tracyjohnsonux
tracyjohnsonux merged commit 97cb722 into main Aug 19, 2026
29 checks passed
@tracyjohnsonux
tracyjohnsonux deleted the fix/group-ai-budget-no-budget branch August 19, 2026 13:15
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants