fix: hide the favorite button for workspaces you don't own - #28000
Merged
Conversation
…ton for non-owners Favorite is a column on the workspace row rather than a per-user relation, so the API rejects favorite and unfavorite requests from anyone other than the workspace owner. The button was rendered unconditionally, so viewing someone else's workspace offered a star that always looked un-favorited and failed with a 403 surfaced through the "Error building workspace" dialog.
DanielleMaywood
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Favorite status lives on the workspace row rather than in a per-user relation, so the API only lets a workspace's owner toggle it. The button was rendered for everyone, so viewing someone else's workspace offered a star that always looked un-favorited and failed with a 403, surfaced through the "Error building workspace" dialog.
Hides the button unless you own the workspace, with stories covering both cases.
Made with Coder Agents on behalf of @aslilac.