fix(codersdk/licenses.go): read trial claim instead of misspelled trail - #28014
Merged
Conversation
jaaydenh
marked this pull request as ready for review
August 11, 2026 10:07
mtojek
approved these changes
Aug 11, 2026
jaaydenh
enabled auto-merge (squash)
August 11, 2026 10:09
Contributor
|
No test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
codersdk.License.Trial()looked up the JWT claim"trail"(a typo) instead of"trial", the actual claim name set by license issuance (enterprise/coderd/license/license.go). Since no license contains a"trail"claim, the method always returnedfalse.The only consumer is
coder licenses list(viacli/cliutil/license.go), so the CLI never reported a license as a trial even when it was one. The web UI is unaffected because it readsclaims.trialdirectly.Changes
"trial"claim inLicense.Trial().Testing
go build/go vetoncodersdkandcli/cliutil.go test -run 'TestLicensesListFake|TestLicensesListReal' ./enterprise/clipasses.