Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site): allow single-label AI provider endpoints - #28122

Merged
johnstcn merged 8 commits into
mainfrom
fix/ai-provider-endpoint-url-validation
Aug 17, 2026
Merged

fix(site): allow single-label AI provider endpoints#28122
johnstcn merged 8 commits into
mainfrom
fix/ai-provider-endpoint-url-validation

Conversation

@johnstcn

@johnstcn johnstcn commented Aug 13, 2026

Copy link
Copy Markdown
Member

Closes #27980.

Reduces the baseUrl field validation in ProviderForm.tsx to only validate non-empty input. The previous validation was not in line with validateAIProviderBaseURL in codersdk/aiproviders.go. This was blocking users from adding providers with a short-form hostname (e.g. http://localhost:8080/v1).

Generated by Coder Agents, reviewed by a human.

@johnstcn
johnstcn marked this pull request as ready for review August 13, 2026 12:13
Copilot AI lite review requested due to automatic review settings August 13, 2026 12:13
@johnstcn

This comment was marked as outdated.

@coder-agents-review

This comment was marked as outdated.

This comment was marked as resolved.

coder-agents-review[bot]

This comment was marked as resolved.

This comment was marked as outdated.

coder-agents-review[bot]

This comment was marked as resolved.

@johnstcn

This comment was marked as outdated.

coder-agents-review[bot]

This comment was marked as resolved.

@johnstcn

This comment was marked as outdated.

johnstcn

This comment was marked as outdated.

URL shape validation belongs to the backend. The form now only
checks that the endpoint is non-empty, and backend base_url
errors surface on the field via field mapping.
@johnstcn

This comment was marked as outdated.

coder-agents-review[bot]

This comment was marked as resolved.

@johnstcn

This comment was marked as outdated.

Comment thread site/src/pages/AISettingsPage/ProvidersPage/components/ProviderForm.tsx Outdated
coder-agents-review[bot]

This comment was marked as outdated.

@johnstcn
johnstcn marked this pull request as ready for review August 17, 2026 22:13

@bpmct bpmct left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for seeing this through @johnstcn

@johnstcn
johnstcn merged commit 444fb8a into main Aug 17, 2026
27 checks passed
@johnstcn
johnstcn deleted the fix/ai-provider-endpoint-url-validation branch August 17, 2026 23:18
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: OpenAI Compatible Provider incorrectly validates Endpoint Base URL

3 participants