Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(docs): fix slack webhook backtick (backport of #28085 to release/2.29) - #28177

Merged
nickvigilante merged 1 commit into
release/2.29from
backport/28085-to-2.29-manual
Aug 24, 2026
Merged

fix(docs): fix slack webhook backtick (backport of #28085 to release/2.29)#28177
nickvigilante merged 1 commit into
release/2.29from
backport/28085-to-2.29-manual

Conversation

@nickvigilante

Copy link
Copy Markdown
Contributor

Backport of #28085 to release/2.29 (ESR).

Replaces the stale automated backport #28164, whose branch was an empty placeholder based on an older release/2.29. This branch is cut from the current release/2.29 tip and cherry-picks 3145cc8386f9 with git cherry-pick -x.

Scope note: only the slack.md fix (removing the stray trailing backtick from the CODER_NOTIFICATIONS_WEBHOOK_ENDPOINT export) applies to 2.29. #28085 also fixed a doubled-prefix metric name in prometheus.md, but release/2.29's native-histograms list does not include coderd_template_workspace_build_duration_seconds at all, so that hunk is intentionally dropped rather than adding a metric 2.29 does not document. The slack.md conflict kept 2.29's bash fence.

Once reviewed, #28164 can be closed in favor of this PR.

This PR was created with AI assistance (Coder Agents).

Two small monitoring-doc fixes surfaced by the runtime drift sweep.

The native-histograms list showed
`coderd_template_coderd_template_workspace_build_duration_seconds`
(doubled `coderd_template_` prefix). The correct metric name, per the
metrics table earlier on the same page and the generated metrics, is
`coderd_template_workspace_build_duration_seconds`.

The `CODER_NOTIFICATIONS_WEBHOOK_ENDPOINT` export ended with a stray
backtick:
```
export CODER_NOTIFICATIONS_WEBHOOK_ENDPOINT=http://localhost:6000/v1/webhook`
```
On paste, bash treats the trailing backtick as an unterminated command
substitution and errors. Removed it.

Both reproduced during the runtime drift sweep and verified against
`main`.

Linear:
[DOCS-647](https://linear.app/codercom/issue/DOCS-647/docs-fix-monitoring-examples-prometheus-metric-name-slack-webhook)

> This PR was created with AI assistance (Coder Agents).

(cherry picked from commit 3145cc8)
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @nickvigilante!

This PR is targeting the release/2.29 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

@nickvigilante nickvigilante changed the title docs: fix slack webhook backtick (backport of #28085 to release/2.29) fix(docs): fix slack webhook backtick (backport of #28085 to release/2.29) Aug 14, 2026
@nickvigilante
nickvigilante marked this pull request as ready for review August 14, 2026 17:46
@nickvigilante
nickvigilante enabled auto-merge (squash) August 14, 2026 17:46
@nickvigilante
nickvigilante requested a review from jcjiang August 14, 2026 17:46

@jcjiang jcjiang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@nickvigilante
nickvigilante merged commit 97980f9 into release/2.29 Aug 24, 2026
32 checks passed
@nickvigilante
nickvigilante deleted the backport/28085-to-2.29-manual branch August 24, 2026 16:10
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants