Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: correct AI Gateway metric provider label and cardinality notes - #28220

Merged
ssncferreira merged 1 commit into
mainfrom
ssncf/provider-metric-labels
Aug 18, 2026
Merged

chore: correct AI Gateway metric provider label and cardinality notes#28220
ssncferreira merged 1 commit into
mainfrom
ssncf/provider-metric-labels

Conversation

@ssncferreira

@ssncferreira ssncferreira commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

The cardinality notes in aibridge/metrics/metrics.go assume the provider label takes one of three values, and two for the key pool metrics. That was accurate when the notes were written: provider is the provider instance name, and the name defaulted to one of the three provider types aibridge supports. Instances can now be given their own names, so the label takes any configured name and the series counts scale with the number of configured providers rather than being capped at a fixed number.

The monitoring docs are also updated to make clear that provider is the provider instance name.

Comments and documentation only, no behaviour change.

Follow-up to #28210.

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ssncferreira
ssncferreira force-pushed the ssncf/provider-metric-labels branch from daf33b4 to 226411a Compare August 18, 2026 09:32
@ssncferreira
ssncferreira marked this pull request as ready for review August 18, 2026 09:32
@ssncferreira
ssncferreira requested a review from johnstcn August 18, 2026 09:33

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp 👍

@ssncferreira
ssncferreira enabled auto-merge (squash) August 18, 2026 09:44
@ssncferreira
ssncferreira merged commit db3566c into main Aug 18, 2026
37 checks passed
@ssncferreira
ssncferreira deleted the ssncf/provider-metric-labels branch August 18, 2026 09:47
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants