fix(site/src/pages/AgentsPage): persist empty MCP selection - #28238
Merged
Conversation
ibetitsmike
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the final optional MCP server from an existing chat produced an empty selection, but the message request omitted
mcp_server_ids. The API interprets an omitted field as preserving the current selection.Send the selected MCP server IDs for every message, including an empty array. Add a Storybook interaction test that removes the final MCP server and verifies the request contains
mcp_server_ids: [].Manual verification on a local dev instance
Setup:
./scripts/develop.sh, an Anthropic provider withclaude-haiku-4-5, and a local test MCP server registered with availabilitydefault_on.With this branch, chat
75285d9f:GET /api/experimental/chats/{id}returnedmcp_server_ids: [].With the one-line change reverted, chat
751ac191repeated the same flow. The chip returned as selected after the reload, and the API returnedmcp_server_ids: ["b63a2a3a-..."].Not covered:
force_onservers, plan mode interaction, and queued messages during streaming.Generated by Coder Agents.