Codestin Search App

jakehwll · 2026-08-18T07:51:31Z

🤖 This PR was modified by Coder Agents on behalf of Jake Howell.

Adds an Install Coder Desktop item to UserDropdown, sitting directly above the existing Install CLI option. Because UserDropdownContent is shared, it appears in both the navbar dropdown and the agents-page sidebar footer.

Screenshots

macOS/Windows shots are captured with navigator.platform overridden accordingly; the Linux shot is the real workspace platform, where the Coder Desktop item is hidden. Install Coder Desktop uses a monitor glyph, and Install CLI now uses a terminal glyph (it was a monitor on main).

`main` (before)	This PR · macOS/Windows	This PR · Linux / iPad OS

Behaviour

Platform-gated visibility: shown only on macOS and Windows (the platforms Coder Desktop ships for), hidden on Linux/other. The Linux client (coder/coder-desktop-linux) is experimental and not advertised yet, so it stays hidden there.
Links to the docs (https://coder.com/docs/user-guides/desktop) rather than a single install method. The docs page is the canonical hub covering Homebrew, WinGet, manual release downloads, and source, and it stays current without frontend changes. The coder-desktop-* repo READMEs don't enumerate install methods; they defer to these same docs.
No installed-detection: consistent with the Install CLI item, we don't try to detect whether Coder Desktop is already present.

Changes

site/src/utils/platform.ts: add isWindows() and supportsCoderDesktop().
UserDropdownContent.tsx: render the platform-gated item (MonitorIcon) and switch Install CLI to TerminalIcon.
Unit tests for the platform helpers and Storybook coverage for the dropdown item (present + correct href on macOS/Windows, absent on Linux/iPadOS).

Implementation plan & decision log

Ticket open questions and decisions

Shown to all users or only supported platforms? Only supported platforms (macOS, Windows); hidden elsewhere. The Linux client is experimental and not advertised yet, so hiding it there is intentional.
Where should it link? The Coder Desktop docs page. Users install via many methods (brew, winget, releases, source); the docs are the single hub that lists them all and are maintained in-repo. The GitHub release pages / repo READMEs only cover downloads and defer back to the docs.
Hide when already installed? No. There is no reliable browser-side way to detect a native app install, and it mirrors how Install CLI behaves.

Implementation

Extend site/src/utils/platform.ts with isWindows() and supportsCoderDesktop() (reusing the existing isMac()).
In UserDropdownContent.tsx, conditionally render an Install Coder Desktop DropdownMenuItem (external link, MonitorIcon, opens in a new tab) above Install CLI when supportsCoderDesktop() is true.
Tests: platform.test.ts (OS detection via vi.stubGlobal) and UserDropdown.stories.tsx (visibility + href per platform, mocking platform detection with spyOn).

Left as a draft pending review, let me know when you'd like it opened.

linear-code · 2026-08-18T07:51:35Z

DEVEX-722

…-button-to-userdropdown

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b0888d846

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-18T08:19:30Z

+ * install affordance everywhere else (e.g. Linux).
+ */
+export function supportsCoderDesktop(): boolean {
+	return isMac() || isWindows();


Exclude iPadOS from macOS desktop support

On iPadOS 13+ Safari in desktop mode, navigator.platform reports MacIntel, so isMac() returns true and this new predicate displays an install option for a platform where Coder Desktop is unavailable. The repository already handles iPadOS masquerading as macOS by checking navigator.maxTouchPoints in site/src/pages/AgentsPage/utils/chatAttachments.ts:69-72; apply an equivalent exclusion here.

Useful? React with 👍 / 👎.

Address Codex review: move UserDropdown platform-gating coverage into Storybook play functions and exclude iPadOS (reports MacIntel with a touchscreen) from supportsCoderDesktop.

matifali

Left a few comments. May be get @chrifro's review too.

Coder Desktop now ships an (experimental) Linux client (coder/coder-desktop-linux), so the install affordance should be shown on Linux too. Add isLinux() and include it in the predicate, keeping the iPadOS exclusion. Addresses review feedback.

The Linux Coder Desktop client (coder/coder-desktop-linux) is experimental and its maintainer isn't comfortable advertising it yet, so revert the earlier change that surfaced the install affordance on Linux. Back to macOS/Windows only.

chrifro

non-blocking

I'd suggest to adjust the icons. Having a download icon for only one of the install actions can be confusing.

Install Coder Desktop https://lucide.dev/icons/monitor?search=termin
Install CLI https://lucide.dev/icons/terminal

I know it's out of scope, but would be great if we only show these options if they have not been installed yet. If we can't fit it into this PR, can we make sure to document it a linear issue to pick up another time?

Address review feedback: a lone download icon on Install CLI next to the Coder Desktop item was confusing. Use the monitor glyph for Install Coder Desktop and the terminal glyph for Install CLI.

Replace the manual Object.defineProperty navigator juggling with vi.stubGlobal in the unit test and spyOn in the story, per review feedback.

jeremyruppel · 2026-08-18T14:12:41Z

+import { supportsCoderDesktop } from "#/utils/platform";
 import { SupportIcon } from "../SupportIcon";

+const CODER_DESKTOP_DOCS_URL = "https://coder.com/docs/user-guides/desktop";


should this use our docs() helper?

Hmm. I like this on main as its more likely to be up to date with the instructions from the individual clients (this isn't synced with Coder <-> Coder Desktop).

I can see why some feedback might be specific to a version and we could back date for said docs. Agent in progress...

Spying the whole window.navigator getter and spreading it dropped prototype getters (e.g. userAgent) that Storybook's client reads, crashing the story in a real browser. Spy the platform and maxTouchPoints getters individually so the rest of navigator stays intact.

🤖 feat(site): add Install Coder Desktop item to UserDropdown

6232546

github-actions Bot assigned jakehwll Aug 18, 2026

jakehwll added 2 commits August 18, 2026 07:54

🤖 chore(site): format UserDropdown Coder Desktop item

a57e973

🤖 feat(site): use AppWindowMac and Download icons in UserDropdown

b69f415

jakehwll requested review from chrifro, jeremyruppel and matifali August 18, 2026 08:11

jakehwll marked this pull request as ready for review August 18, 2026 08:17

jakehwll and others added 2 commits August 18, 2026 15:17

Merge branch 'main' into jakehwll/devex-722-add-install-coder-desktop…

8b0888d

…-button-to-userdropdown

🤖 chore(site): drop redundant comment in UserDropdownContent

dacbb53

chatgpt-codex-connector Bot reviewed Aug 18, 2026

View reviewed changes

🤖 test(site): cover Coder Desktop gating in Storybook, exclude iPadOS

5a8f47f

Address Codex review: move UserDropdown platform-gating coverage into Storybook play functions and exclude iPadOS (reports MacIntel with a touchscreen) from supportsCoderDesktop.

matifali reviewed Aug 18, 2026

View reviewed changes

Comment thread site/src/utils/platform.ts

Comment thread site/src/utils/platform.test.ts

Comment thread site/src/utils/platform.test.ts Outdated

This comment was marked as outdated.

Sign in to view

blinkagent Bot mentioned this pull request Aug 18, 2026

Use platform detection to render OS-specific install instructions in UserDropdown #28252

Open

matifali approved these changes Aug 18, 2026

View reviewed changes

chrifro approved these changes Aug 18, 2026

View reviewed changes

jeremyruppel reviewed Aug 18, 2026

View reviewed changes

Comment thread site/src/modules/dashboard/Navbar/UserDropdown/UserDropdown.stories.tsx

jeremyruppel reviewed Aug 18, 2026

View reviewed changes

Comment thread site/src/utils/platform.test.ts Outdated

jakehwll added 2 commits August 18, 2026 14:09

🤖 feat(site): use monitor and terminal icons for install dropdown

e5aec2c

Address review feedback: a lone download icon on Install CLI next to the Coder Desktop item was confusing. Use the monitor glyph for Install Coder Desktop and the terminal glyph for Install CLI.

🤖 test(site): use vi.stubGlobal and spyOn for platform mocking

dd0ce30

Replace the manual Object.defineProperty navigator juggling with vi.stubGlobal in the unit test and spyOn in the story, per review feedback.

jakehwll requested a review from jeremyruppel August 18, 2026 14:11

jeremyruppel reviewed Aug 18, 2026

View reviewed changes

jeremyruppel approved these changes Aug 18, 2026

View reviewed changes

jakehwll merged commit 4d13bef into main Aug 19, 2026
30 checks passed

jakehwll deleted the jakehwll/devex-722-add-install-coder-desktop-button-to-userdropdown branch August 19, 2026 02:11

github-actions Bot locked and limited conversation to collaborators Aug 19, 2026

Navigation Menu

Uh oh!

feat(site): add Install Coder Desktop item to UserDropdown - #28244

feat(site): add Install Coder Desktop item to UserDropdown#28244
jakehwll merged 11 commits into
mainfrom
jakehwll/devex-722-add-install-coder-desktop-button-to-userdropdown

jakehwll commented Aug 18, 2026 •

edited

Loading

Uh oh!

linear-code Bot commented Aug 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot Aug 18, 2026

Uh oh!

matifali left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

chrifro left a comment

Uh oh!

Uh oh!

Uh oh!

jeremyruppel Aug 18, 2026

Uh oh!

jakehwll Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jakehwll commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Behaviour

Changes

Uh oh!

linear-code Bot commented Aug 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

matifali left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

chrifro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jeremyruppel Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

jakehwll Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jakehwll commented Aug 18, 2026 •

edited

Loading

matifali left a comment •

edited

Loading