fix(site/src/pages/AgentsPage): disallow queued message edits - #28265
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ce6254304
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
a7910d6 to
26e8d89
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Closes CODAGT-230.
Selecting "Edit queued message" in Agent Chat did not stop the queued message from sending: edit mode was purely client-side state, so at turn end the backend promoted the queued message and sent it anyway, leaving the UI stuck in a stale "Editing queued message" state with the send button showing "Save".
This removes queued-message editing entirely instead of adding backend locking. Queued messages can still be promoted ("Send now") and deleted ("Remove from queue"); editing already-sent history messages is unchanged.
Changes
QueuedMessagesList), the "Editing queued message" banner and "Save" button label (AgentChatInput), and the queue-edit state, handlers, and prop plumbing (AgentChatPage,AgentChatPageView,ChatPageContent).rawText/fileBlocksfields ofgetQueuedMessageInfo.isEditingHistoryMessageprop onChatPageInput, which had become identical toisEditing, and stop discarding the delete/promote promises soQueuedMessagesListbusy state works again.ActionsExcludeEditregression story asserting queued rows expose "Send now" and "Remove from queue" but no "Edit" button.Testing
pnpm -C site check,pnpm -C site lint:types.AgentChatPage.test.ts,QueuedMessagesList.test.ts(92 tests). Storybook: all four touched story files (102 tests). A pre-existing unhandled xterm error inAgentChatPageView.stories.tsxreproduces identically at the merge base.