Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site/src/pages/AgentsPage): disallow queued message edits - #28265

Merged
ibetitsmike merged 3 commits into
mainfrom
mike/codagt-230-disallow-queued-message-edits
Aug 18, 2026
Merged

fix(site/src/pages/AgentsPage): disallow queued message edits#28265
ibetitsmike merged 3 commits into
mainfrom
mike/codagt-230-disallow-queued-message-edits

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Closes CODAGT-230.

Selecting "Edit queued message" in Agent Chat did not stop the queued message from sending: edit mode was purely client-side state, so at turn end the backend promoted the queued message and sent it anyway, leaving the UI stuck in a stale "Editing queued message" state with the send button showing "Save".

This removes queued-message editing entirely instead of adding backend locking. Queued messages can still be promoted ("Send now") and deleted ("Remove from queue"); editing already-sent history messages is unchanged.

Changes

  • Remove the Edit pencil from queued message rows (QueuedMessagesList), the "Editing queued message" banner and "Save" button label (AgentChatInput), and the queue-edit state, handlers, and prop plumbing (AgentChatPage, AgentChatPageView, ChatPageContent).
  • Remove the queued-edit save flow that deleted the original queued row and re-queued a new message, plus the now-unused rawText/fileBlocks fields of getQueuedMessageInfo.
  • Drop the redundant isEditingHistoryMessage prop on ChatPageInput, which had become identical to isEditing, and stop discarding the delete/promote promises so QueuedMessagesList busy state works again.
  • Replace the queued-edit stories and tests with an ActionsExcludeEdit regression story asserting queued rows expose "Send now" and "Remove from queue" but no "Edit" button.

Testing

  • pnpm -C site check, pnpm -C site lint:types.
  • Unit: AgentChatPage.test.ts, QueuedMessagesList.test.ts (92 tests). Storybook: all four touched story files (102 tests). A pre-existing unhandled xterm error in AgentChatPageView.stories.tsx reproduces identically at the merge base.
  • Remote dogfood UAT passed on a dev.coder.com workspace with a real model: no edit affordance on queued rows, queued delete and turn-end promotion still work, history-message editing and Escape behavior unaffected.

Mux acted on behalf of Mike for this pull request.

@linear-code

linear-code Bot commented Aug 18, 2026

Copy link
Copy Markdown

CODAGT-230

@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ce6254304

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/src/pages/AgentsPage/components/QueuedMessagesList.stories.tsx
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: a7910d6d7f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike
ibetitsmike force-pushed the mike/codagt-230-disallow-queued-message-edits branch from a7910d6 to 26e8d89 Compare August 18, 2026 16:09
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 26e8d89f3f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike
ibetitsmike marked this pull request as ready for review August 18, 2026 17:15
@ibetitsmike
ibetitsmike merged commit ba5717d into main Aug 18, 2026
30 of 31 checks passed
@ibetitsmike
ibetitsmike deleted the mike/codagt-230-disallow-queued-message-edits branch August 18, 2026 17:34
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants