fix: gate group settings page and fix unauthorized group patch - #28314
Merged
ssncferreira merged 1 commit intoAug 20, 2026
Merged
Conversation
ssncferreira
force-pushed
the
susana/aigov-603-hide-group-budget-controls-without-permission
branch
2 times, most recently
from
August 20, 2026 12:15
7587ea9 to
653c03c
Compare
Updating a group (e.g. its budget) as a user without group:update returned a 400 "Failed to add or remove non-existent group member" because the authorization failure was misclassified. Return the standard vague 404 for unauthorized errors so the response is accurate and does not leak resource existence, and use a generic message for the remaining 400 branch since it covers various transaction failures. Also gate the group settings page on group:update. The settings tab is already hidden without the permission, but the page was reachable by direct URL and rendered an editable form that always failed on save. It now shows the standard permission dialog.
ssncferreira
force-pushed
the
susana/aigov-603-hide-group-budget-controls-without-permission
branch
from
August 20, 2026 12:23
653c03c to
420ba02
Compare
ssncferreira
marked this pull request as ready for review
August 20, 2026 12:25
EhabY
approved these changes
Aug 20, 2026
EhabY
left a comment
Contributor
There was a problem hiding this comment.
Makes sense, glad it's fixed now!
johnstcn
approved these changes
Aug 20, 2026
ssncferreira
deleted the
susana/aigov-603-hide-group-budget-controls-without-permission
branch
August 20, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A user without
group:update(e.g. theCoder Agents Userrole) could open the group settings page by direct URL and edit the budget. Saving then failed with a misleading error:The authorization failure was misclassified as a missing group member, and the settings page was not gated on the required permission.
Changes
group:update. The settings tab is already hidden without the permission, but the page was reachable by direct URL and rendered an editable form that always failed on save. It now shows the standard permission dialog.Fixes AIGOV-603.
Note
Generated by Coder Agents, reviewed by @ssncferreira.