-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: canonicalize API key scope aliases at ingress #28322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+232
−50
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4a402d3
fix(coderd): canonicalize API key scope aliases at ingress
BobbyHo d9753b5
fix: canonicalize API key scopes in apikey.Generate
BobbyHo cdc233e
Merge branch 'main' into plat479-1a-apikey-scope-aliases
BobbyHo e827a27
docs: use a relative link for the max token lifetime flag
BobbyHo 5b7b46d
fix(coderd): list every external scope name ingress accepts
BobbyHo 7105b63
fix(coderd): give apikey.Generate sole ownership of scope canonicaliz…
BobbyHo 5add97a
refactor(coderd/apikey): say clone with slices.Clone and fix a comment
BobbyHo 50d4e03
docs: name the scopes a token cannot request
BobbyHo 0840e30
Merge branch 'main' into plat479-1a-apikey-scope-aliases
BobbyHo fef8883
test(coderd): name the scope tests for what they assert
BobbyHo 3c905fa
docs(coderd): cut the scope comments down to what the code does
BobbyHo f1b1269
Merge branch 'main' into plat479-1a-apikey-scope-aliases
BobbyHo 387e743
Update coderd/apikey/apikey.go
BobbyHo 89cbcce
Update coderd/apikey/apikey.go
BobbyHo c3d1f7b
Merge branch 'main' into plat479-1a-apikey-scope-aliases
BobbyHo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.