Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(site): add provider icon to chat model selector #28330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielleMaywood merged 4 commits into from
Aug 20, 2026
+67 −1
Merged

feat(site): add provider icon to chat model selector #28330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e8573f
feat(site): add provider icon to chat model selector
DanielleMaywood Aug 20, 2026
2662d94
fix(site): align model selector pill padding with workspace and MCP p…
DanielleMaywood Aug 20, 2026
afffed7
Update site/src/pages/AgentsPage/components/ChatElements/ModelSelecto…
DanielleMaywood Aug 20, 2026
d66dd07
test(site): use testid for provider icon stories and drop restating c…
DanielleMaywood Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions site/src/pages/AgentsPage/components/ChatElements/ModelSelector.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,63 @@ export const WithSelectedValue: Story = {
},
};

export const SelectedValueShowsProviderIcon: Story = {
args: {
options: allModels,
value: "anthropic/claude-sonnet-4",
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
expect(
canvas.getByRole("combobox", { name: "Claude Sonnet 4" }),
).toBeInTheDocument();
expect(
canvas.getByTestId("model-selector-trigger-icon"),
).toBeInTheDocument();
},
};

export const SelectedValueShowsCustomProviderIcon: Story = {
args: {
options: [
{
...MockModelSelectorOption,
id: "anthropic-hyper/claude-opus-4",
provider: "anthropic",
providerId: "provider-anthropic-hyper",
providerLabel: "Hyper",
providerIcon: "/icon/coder.svg",
model: "claude-opus-4-20250514",
displayName: "Claude Opus 4",
},
],
value: "anthropic-hyper/claude-opus-4",
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
expect(
canvas.getByRole("combobox", { name: "Claude Opus 4" }),
).toBeInTheDocument();
const icon = canvas.getByTestId("model-selector-trigger-icon");
expect(icon.querySelector("img")).toHaveAttribute("src", "/icon/coder.svg");
},
};

export const PlaceholderShowsNoIcon: Story = {
args: {
value: "",
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
expect(
canvas.getByRole("combobox", { name: "Select model" }),
).toBeInTheDocument();
expect(
canvas.queryByTestId("model-selector-trigger-icon"),
).not.toBeInTheDocument();
},
};

export const CustomTriggerLabel: Story = {
args: {
options: openAIModels,
Expand Down
11 changes: 10 additions & 1 deletion site/src/pages/AgentsPage/components/ChatElements/ModelSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,20 @@ export const ModelSelector: FC<ModelSelectorProps> = ({
type="button"
variant="subtle"
className={cn(
"h-7 md:h-auto min-w-0 shrink justify-start gap-0.5 rounded-full border-0 bg-surface-secondary px-1 py-0.5 text-xs font-medium shadow-none transition-colors hover:bg-surface-tertiary hover:text-content-primary focus:ring-0 focus-visible:ring-2 focus-visible:ring-content-link md:w-auto md:shrink-0 md:gap-1.5 [&>svg]:!size-3.5 [&>svg]:p-0 [&>svg]:shrink-0 [&>svg]:transition [&>svg]:hover:text-content-primary",
"h-7 md:h-auto min-w-0 shrink justify-start gap-1 rounded-full border-0 bg-surface-secondary px-2 py-0.5 text-xs font-medium shadow-none transition-colors hover:bg-surface-tertiary hover:text-content-primary focus:ring-0 focus-visible:ring-2 focus-visible:ring-content-link md:w-auto md:shrink-0 [&>svg]:!size-3.5 [&>svg]:p-0 [&>svg]:shrink-0 [&>svg]:transition [&>svg]:hover:text-content-primary [&>img]:!size-3 [&>img]:!p-0",
className,
)}
onTouchStart={onTriggerTouchStart}
>
{selectedModel && (
<span data-testid="model-selector-trigger-icon">
<ProviderIcon
provider={selectedModel.provider}
icon={selectedModel.providerIcon}
className="size-3 shrink-0"
/>
</span>
)}
<span className="truncate">{triggerLabel}</span>
<ChevronDownIcon open={open} />
</Button>
Expand Down
Loading