refactor(coderd/x/chatd): return PersistedStep directly from ExecuteLocalTools - #28359
Merged
jaaydenh merged 1 commit intoAug 25, 2026
Merged
Conversation
This was referenced Aug 20, 2026
jaaydenh
force-pushed
the
jaayden/codagt-928-stack-1-refactor-execute-local-tools
branch
from
August 20, 2026 09:11
e00443e to
c226ac5
Compare
jaaydenh
marked this pull request as ready for review
August 20, 2026 09:15
jaaydenh
force-pushed
the
jaayden/codagt-928-stack-1-refactor-execute-local-tools
branch
5 times, most recently
from
August 24, 2026 09:52
f79c392 to
ac46178
Compare
hugodutka
approved these changes
Aug 24, 2026
jaaydenh
force-pushed
the
jaayden/codagt-928-stack-1-refactor-execute-local-tools
branch
3 times, most recently
from
August 24, 2026 18:03
9d1de01 to
4eaa046
Compare
…ocalTools ToolExecutionOutcome only wrapped a PersistedStep, so callers had to reach through outcome.Step for every field. Returning the step directly removes the wrapper with no behavior change.
jaaydenh
force-pushed
the
jaayden/codagt-928-stack-1-refactor-execute-local-tools
branch
from
August 25, 2026 09:09
4eaa046 to
dc6f8d0
Compare
jaaydenh
deleted the
jaayden/codagt-928-stack-1-refactor-execute-local-tools
branch
August 25, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #28359 (this PR) → #28360 → #28361 → #28362
chatloop.ToolExecutionOutcomeonly wrapped aPersistedStep, so callers had to reach throughoutcome.Stepfor every field.ExecuteLocalToolsnow returns thePersistedStepdirectly and the wrapper type is deleted. No behavior change.First of a four-PR stack that makes local tool execution count toward Coder Agent runtime (splitting #28211). This refactor keeps the rename noise out of the feature PRs.
Refs CODAGT-928 (https://linear.app/codercom/issue/CODAGT-928/track-local-tool-execution-for-agent-runtime).