fix: require audit capture for chat settings - #28394
Merged
ethanndickson merged 2 commits intoAug 24, 2026
Merged
Conversation
ethanndickson
marked this pull request as ready for review
August 20, 2026 15:54
ethanndickson
force-pushed
the
ethan/codagt-720-fail-closed-chat-settings-audit
branch
from
August 20, 2026 16:03
0efe4f2 to
a82abed
Compare
ibetitsmike
approved these changes
Aug 24, 2026
ethanndickson
force-pushed
the
ethan/codagt-720-fail-closed-chat-settings-audit
branch
from
August 24, 2026 09:21
a82abed to
659ffc1
Compare
ethanndickson
force-pushed
the
ethan/codagt-720-fail-closed-chat-settings-audit
branch
from
August 24, 2026 10:39
659ffc1 to
5329ab9
Compare
ethanndickson
deleted the
ethan/codagt-720-fail-closed-chat-settings-audit
branch
August 24, 2026 10:53
ethanndickson
added a commit
that referenced
this pull request
Aug 24, 2026
Depends on #28394. Audit changes to seven operational agent settings through a typed `chat_operational_settings` resource. Each handler serializes baseline capture and mutation with a per-setting advisory lock, keeps both operations in one transaction, and records field-specific diffs. Effective no-op requests now skip both the database upsert and the success audit, including absent rows whose effective value is already the default. The change also retains the allowlisted raw `site_configs` query, updates generated audit and API surfaces, adds failure and concurrency coverage, and reuses the existing AuditPage resource-filter story pattern. Relates to CODAGT-720.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing chat instruction setting handlers could complete a mutation without an audit event when advisory locking or old-state capture failed.
Make system prompt and plan mode instruction updates fail closed: baseline capture and mutation stay in one transaction, audit infrastructure failures reject the request without changing the setting, and focused tests cover lock, read, transaction, and write failures.