Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site/src): give built-in emoji avatars a consistent inset #28492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tracyjohnsonux merged 14 commits into from
Aug 25, 2026
Merged

fix(site/src): give built-in emoji avatars a consistent inset #28492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cb513c1
fix(site/src/components/Avatar): pad built-in emoji avatars like icons
tracyjohnsonux Aug 24, 2026
59fd662
fix(site/src/components/Avatar): use proportional inset for emoji ava…
tracyjohnsonux Aug 24, 2026
18d13eb
fix(site/src/components/Avatar): apply emoji inset regardless of variant
tracyjohnsonux Aug 24, 2026
43943f7
refactor(site/src/components/Avatar): model emoji inset as a cva variant
tracyjohnsonux Aug 24, 2026
178e2be
chore(site/src/components/Avatar): drop call-site-specific emoji story
tracyjohnsonux Aug 24, 2026
12b8720
chore(site/src/components/Avatar): tighten emoji variant comments
tracyjohnsonux Aug 24, 2026
3409c17
Merge branch 'main' into fix/emoji-avatar-padding
tracyjohnsonux Aug 25, 2026
876729d
refactor(site/src): address emoji avatar review feedback
tracyjohnsonux Aug 25, 2026
114b11b
Merge branch 'fix/emoji-avatar-padding' of https://github.com/coder/c…
tracyjohnsonux Aug 25, 2026
56ea374
🤖 refactor(site/src): use style prop for emoji padding
jakehwll Aug 25, 2026
4b8edf8
🤖 refactor(site/src): simplify emoji avatar padding
jakehwll Aug 25, 2026
b9367b4
🤖 refactor(site/src): preserve avatar style padding
jakehwll Aug 25, 2026
5f12cd6
🤖 refactor(site/src): inline emoji asset paths
jakehwll Aug 25, 2026
169f30a
🤖 refactor(site/src): remove emoji avatar variant
jakehwll Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions site/src/components/Avatar/Avatar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,26 @@ export const NonSquaredIcon: Story = {
},
};

export const BuiltInEmojiLgSize: Story = {
args: {
size: "lg",
src: "/emojis/1f64c.png",
},
};

export const BuiltInEmojiMdSize: Story = {
args: {
src: "/emojis/1f64c.png",
},
};

export const BuiltInEmojiSmSize: Story = {
args: {
size: "sm",
src: "/emojis/1f64c.png",
},
};

export const FallbackLgSize: Story = {
args: {
src: "",
Expand Down
15 changes: 14 additions & 1 deletion site/src/components/Avatar/Avatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,26 @@ export const Avatar: React.FC<AvatarProps> = ({
fallback,
alt = "",
children,
style,
...props
}) => {
const { externalImages } = useAppearance();

const isEmoji = src?.startsWith("/emojis/");

return (
<AvatarPrimitive.Root
className={cn(avatarVariants({ size, variant, className }))}
className={cn(
avatarVariants({
size,
variant: isEmoji ? "default" : variant,
className,
}),
)}
style={{
...style,
padding: isEmoji ? "20%" : style?.padding,
}}
{...props}
>
<AvatarPrimitive.Image
Expand Down
Loading