Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site): harden organization-scoped model loading - #28495

Merged
ethanndickson merged 2 commits into
mainfrom
fix/organization-scoped-model-loading
Aug 25, 2026
Merged

fix(site): harden organization-scoped model loading#28495
ethanndickson merged 2 commits into
mainfrom
fix/organization-scoped-model-loading

Conversation

@ethanndickson

@ethanndickson ethanndickson commented Aug 24, 2026

Copy link
Copy Markdown
Member

Previously, the new agent form treated the dashboard organization as a usable resource scope while permission filtering was still pending. This could request a provisional empty model catalog, briefly show the no-model setup notice, and lose the selected organization when the form remounted. A malformed organization models response could also crash the Models settings page.

Wait for authoritative permitted organizations before enabling organization-scoped resources, persist valid organization selections across remounts, and reject malformed model responses while retaining a defensive rendering guard.

UAT

An adversarial Coder Agents UAT run validated this commit on a licensed local deployment with two organizations, a real Anthropic model, and a non-admin user. Under throttled and artificially delayed authorization, no organization-scoped request fired before permissions settled and the false setup notice never appeared, while an authorized zero-model organization still showed the genuine notice. Persistence across reloads, tampered or stale localStorage IDs, membership revocation, attachment-preserving organization switches, single-organization deployments, and induced malformed or failed model responses on the Models settings page all behaved correctly. Verdict: PASS.

@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@ethanndickson
ethanndickson force-pushed the fix/organization-scoped-model-loading branch from aecd2a3 to c07992d Compare August 25, 2026 10:09

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aecd2a3432

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/src/pages/AgentsPage/components/AgentCreateForm.tsx Outdated

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 82b618f76f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson
ethanndickson enabled auto-merge (squash) August 25, 2026 10:24
@ethanndickson
ethanndickson merged commit d667d68 into main Aug 25, 2026
26 checks passed
@ethanndickson
ethanndickson deleted the fix/organization-scoped-model-loading branch August 25, 2026 10:25
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants