Thanks to visit codestin.com
Credit goes to github.com

Skip to content

revert(site): remove built-in emoji avatar inset #28533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakehwll merged 2 commits into from
Aug 25, 2026
Merged

revert(site): remove built-in emoji avatar inset #28533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78392a4
🤖 revert(site): remove built-in emoji avatar inset
jakehwll Aug 25, 2026
5b8da41
🤖 chore: bump pull request
jakehwll Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions site/src/components/Avatar/Avatar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,26 +53,6 @@ export const NonSquaredIcon: Story = {
},
};

export const BuiltInEmojiLgSize: Story = {
args: {
size: "lg",
src: "/emojis/1f64c.png",
},
};

export const BuiltInEmojiMdSize: Story = {
args: {
src: "/emojis/1f64c.png",
},
};

export const BuiltInEmojiSmSize: Story = {
args: {
size: "sm",
src: "/emojis/1f64c.png",
},
};

export const FallbackLgSize: Story = {
args: {
src: "",
Expand Down
15 changes: 1 addition & 14 deletions site/src/components/Avatar/Avatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,26 +73,13 @@ export const Avatar: React.FC<AvatarProps> = ({
fallback,
alt = "",
children,
style,
...props
}) => {
const { externalImages } = useAppearance();

const isEmoji = src?.startsWith("/emojis/");

return (
<AvatarPrimitive.Root
className={cn(
avatarVariants({
size,
variant: isEmoji ? "default" : variant,
className,
}),
)}
style={{
...style,
padding: isEmoji ? "20%" : style?.padding,
}}
className={cn(avatarVariants({ size, variant, className }))}

This comment was marked as low quality.

Sign in to view

{...props}
>
<AvatarPrimitive.Image
Expand Down
Loading