Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: clarify AI provider collision warnings - #28549

Merged
ssncferreira merged 7 commits into
mainfrom
fix/ai-provider-warning-contract
Aug 26, 2026
Merged

fix: clarify AI provider collision warnings#28549
ssncferreira merged 7 commits into
mainfrom
fix/ai-provider-warning-contract

Conversation

@ssncferreira

@ssncferreira ssncferreira commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

AI provider collision warnings were only partially asserted, and the update coverage did not exercise a provider changing from a distinct hostname to a colliding hostname.

Assert the complete warning consistently across create, get, list, and update responses, cover collisions introduced by base URL and enabled-state updates, and only return the proxy-specific warning when AI Gateway Proxy is enabled. Clarify that lifecycle status values are reported by the provider metrics.

Follow-up to #28208.

Note

Generated by Coder Agents for @ssncferreira.

@github-actions

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@ssncferreira ssncferreira changed the title test(coderd): strengthen provider warning coverage test: strengthen AI provider warning coverage Aug 25, 2026
@ssncferreira ssncferreira changed the title test: strengthen AI provider warning coverage fix: clarify AI provider collision warnings Aug 25, 2026
@ssncferreira
ssncferreira marked this pull request as ready for review August 25, 2026 17:00
@ssncferreira
ssncferreira requested a review from pawbana August 25, 2026 17:00
Comment thread coderd/ai_providers.go Outdated
@ssncferreira
ssncferreira marked this pull request as draft August 26, 2026 08:13
@ssncferreira
ssncferreira force-pushed the fix/ai-provider-warning-contract branch 3 times, most recently from 2b2bd78 to 3dcd067 Compare August 26, 2026 08:50
@ssncferreira
ssncferreira force-pushed the fix/ai-provider-warning-contract branch from 3dcd067 to f4d6968 Compare August 26, 2026 08:53
@ssncferreira
ssncferreira marked this pull request as ready for review August 26, 2026 09:03
@ssncferreira
ssncferreira merged commit 56c6144 into main Aug 26, 2026
31 checks passed
@ssncferreira
ssncferreira deleted the fix/ai-provider-warning-contract branch August 26, 2026 10:12
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants