Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions site/src/modules/permissions/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,22 @@ export const canAccessAnyChatModelConfig = (
);
};

/**
* Whether the user can open the Coder Agents settings page at
* /ai/settings/coder-agents. Deployment admins manage deployment-wide
* agent settings, and organization model admins manage their
* organizations' model configurations on the same page.
*/
export const canAccessCoderAgentsSettings = (
permissions: Permissions | undefined,
): boolean => {
return (
permissions !== undefined &&
(permissions.editDeploymentConfig ||
canAccessAnyChatModelConfig(permissions))
);
};

export const canViewDeploymentSettings = (
permissions: Permissions | undefined,
): permissions is Permissions => {
Expand Down
20 changes: 20 additions & 0 deletions site/src/pages/AgentsPage/AgentsPageLayout.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1206,6 +1206,26 @@ export const OpensSettingsForNonAdmins: Story = {
},
};

export const OpensSettingsForOrgModelAdmins: Story = {
parameters: {
permissions: {
...MockNoPermissions,
editAnyChatModelConfig: true,
},
},
play: async ({ canvasElement }) => {
await openSettingsView(canvasElement);

const manageAgentsLink = await screen.findByRole("link", {
name: "Manage agents",
});
expect(manageAgentsLink).toHaveAttribute(
"href",
"/ai/settings/coder-agents",
);
},
};

export const OpensAISettingsFromManageAgentsOnMobile: Story = {
parameters: {
viewport: { defaultViewport: "mobile1" },
Expand Down
3 changes: 3 additions & 0 deletions site/src/pages/AgentsPage/AgentsPageLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ import {
getDefaultOrganizationName,
useDashboard,
} from "#/modules/dashboard/useDashboard";
import { canAccessCoderAgentsSettings } from "#/modules/permissions";
import { cn } from "#/utils/cn";
import { pageTitle } from "#/utils/page";
import { createReconnectingWebSocket } from "#/utils/reconnectingWebSocket";
Expand Down Expand Up @@ -170,6 +171,7 @@ const AgentsPageLayout: FC = () => {
const personalOverridesOrganizationId =
defaultOrganizationId || (organizations[0]?.id ?? "");
const isAgentsAdmin = permissions.editDeploymentConfig;
const canManageAgentSettings = canAccessCoderAgentsSettings(permissions);

const [sidebarFilters, setSidebarFilters] = getAgentSidebarFilters(
searchParams,
Expand Down Expand Up @@ -791,6 +793,7 @@ const AgentsPageLayout: FC = () => {
personalModelOverridesQuery.data?.enabled
}
isAdmin={isAgentsAdmin}
canManageAgentSettings={canManageAgentSettings}
/>
</ResizableChatsSidebarFrame>
<div
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2690,6 +2690,7 @@ export const SettingsUserAgentsAdmin: Story = {
args: {
chats: [],
isAdmin: true,
canManageAgentSettings: true,
},
parameters: {
reactRouter: reactRouterParameters({
Expand All @@ -2711,6 +2712,40 @@ export const SettingsUserAgentsAdmin: Story = {
},
};

export const SettingsManageAgentsOrgModelAdmin: Story = {
args: {
chats: [],
isAdmin: false,
canManageAgentSettings: true,
},
parameters: {
queries: [
{
key: userChatProviderConfigsKey,
data: [],
},
],
reactRouter: reactRouterParameters({
location: { path: "/agents/settings/general" },
routing: settingsRouting,
}),
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
const manageAgentsLink = await canvas.findByRole("link", {
name: "Manage agents",
});
expect(manageAgentsLink).toHaveAttribute(
"href",
"/ai/settings/coder-agents",
);
// API-key visibility stays tied to isAdmin and configured providers.
expect(
canvas.queryByRole("link", { name: "Secrets (API keys)" }),
).not.toBeInTheDocument();
},
};

export const PreservesArchivedFilterOnSettingsNavigation: Story = {
args: {
chats: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ interface ChatsSidebarProps {
onCollapse?: () => void;
isPersonalModelOverridesEnabled?: boolean;
isAdmin?: boolean;
/**
* Whether the user can open the Coder Agents settings page. Broader
* than isAdmin: organization model admins qualify without deployment
* config access.
*/
canManageAgentSettings?: boolean;
currentUserId: string;
}

Expand Down Expand Up @@ -85,6 +91,7 @@ export const ChatsSidebar: FC<ChatsSidebarProps> = (props) => {
onCollapse,
isPersonalModelOverridesEnabled = false,
isAdmin = false,
canManageAgentSettings = false,
currentUserId,
} = props;
const { agentId, chatId } = useParams<{
Expand Down Expand Up @@ -156,7 +163,7 @@ export const ChatsSidebar: FC<ChatsSidebarProps> = (props) => {
settingsSection={settingsSection}
showApiKeysItem={showApiKeysItem}
isPersonalModelOverridesEnabled={isPersonalModelOverridesEnabled}
isAdmin={isAdmin}
canManageAgentSettings={canManageAgentSettings}
location={location}
onCollapse={onCollapse}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ interface SettingsPanelProps {
readonly settingsSection: string | undefined;
readonly showApiKeysItem: boolean;
readonly isPersonalModelOverridesEnabled: boolean;
readonly isAdmin: boolean;
readonly canManageAgentSettings: boolean;
readonly location: Location;
readonly onCollapse?: () => void;
}
Expand All @@ -30,7 +30,7 @@ export const SettingsPanel: FC<SettingsPanelProps> = ({
settingsSection,
showApiKeysItem,
isPersonalModelOverridesEnabled,
isAdmin,
canManageAgentSettings,
location,
onCollapse,
}) => {
Expand Down Expand Up @@ -113,7 +113,7 @@ export const SettingsPanel: FC<SettingsPanelProps> = ({
state={location.state}
/>
)}
{isAdmin && (
{canManageAgentSettings && (
<SettingsNavItem
icon={Settings2Icon}
label="Manage agents"
Expand Down
Loading