feat(coderd): add include_related parser in its own package - #28639
Merged
Conversation
spikecurtis
marked this pull request as ready for review
August 26, 2026 14:17
cstyan
approved these changes
Aug 31, 2026
cstyan
left a comment
Contributor
There was a problem hiding this comment.
just one organizational related nit
Comment on lines
+27
to
+60
| func (c *Config) ensureLatestBuild() *LatestBuild { | ||
| if c.LatestBuild == nil { | ||
| c.LatestBuild = &LatestBuild{} | ||
| } | ||
| return c.LatestBuild | ||
| } | ||
|
|
||
| func (c *LatestBuild) ensureJob() *Job { | ||
| if c.Job == nil { | ||
| c.Job = &Job{} | ||
| } | ||
| return c.Job | ||
| } | ||
|
|
||
| func (c *LatestBuild) ensureResources() *Resources { | ||
| if c.Resources == nil { | ||
| c.Resources = &Resources{} | ||
| } | ||
| return c.Resources | ||
| } | ||
|
|
||
| func (c *Resources) ensureAgents() *Agents { | ||
| if c.Agents == nil { | ||
| c.Agents = &Agents{} | ||
| } | ||
| return c.Agents | ||
| } | ||
|
|
||
| func (c *Agents) ensureApps() *Apps { | ||
| if c.Apps == nil { | ||
| c.Apps = &Apps{} | ||
| } | ||
| return c.Apps | ||
| } |
Contributor
There was a problem hiding this comment.
nit but IMO functions for these structs should live in related.go where the structs themselves are defined
spikecurtis
force-pushed
the
spikecurtis/include-related-parser
branch
from
September 11, 2026 12:55
f09635b to
5a292bb
Compare
spikecurtis
enabled auto-merge (squash)
September 11, 2026 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the lite
codersdk.Workspacework (GRU-82, RFC), following #28302 and #28367.This adds a self-contained
coderd/wsrelatedpackage that models which workspace-related database objects to load and parses theinclude_relatedquery parameter into that model. The related-data selection type and constructors that previously lived incoderdmove here (now exported aswsrelated.Config,wsrelated.LatestBuild, etc., withwsrelated.All), andcoderduses the package.wsrelated.Parseaccepts a comma-separated list of dotted hierarchy paths, e.g.template,latest_build.resources.agents.*. Each path may end in a single trailing*wildcard that selects the node and all of its descendants;*on its own selects everything. Selecting a node selects its ancestors, which is a structural invariant of the pointer-tree type (a child cannot be expressed without its parent). Unknown paths, misplaced wildcards, and empty entries (e.g.a,,b) are errors; a single optional trailing comma is allowed. The parsing schema is built once ininitrather than per call.This is parser-only to keep the PR small; wiring
Parseinto the HTTP endpoints that producecodersdk.Workspaceobjects comes in a follow-up.Generated by Coder Agents on behalf of @spikecurtis.