feat(site/src/pages/TemplateBuilder): move sensitive-var note into module card - #28731
Merged
Conversation
…dule card Render the 'collected from developers at workspace creation' note inside the module's grey card, after the configuration section, instead of as a sibling below the card. Add a sensitiveVariables prop to ModuleConfiguration and stop rendering the note in ModuleSettingsStep. Isolated slice of #27077 (item 3). DEVEX-829.
aqandrew
marked this pull request as ready for review
September 2, 2026 23:24
chrifro
approved these changes
Sep 3, 2026
chrifro
left a comment
Contributor
There was a problem hiding this comment.
While you're touching this anyway, could you use the smaller icon size for the i icon. Currently 18px, should be 14px 🙏
jeremyruppel
approved these changes
Sep 4, 2026
Contributor
Author
For sure, done in 157cfef! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the module sensitive-variable note ("
<var>will be collected from developers at workspace creation.") inside the module's grey configuration card, positioned after the configuration section, instead of rendering it as a sibling<div>below the card.Resolves DEVEX-829. This is an isolated slice of #27077 (its item 3), rebased onto current
main; nothing else from that PR is included.Why
The note describes variables belonging to a specific module, so it reads more clearly attributed when it lives within that module's card rather than floating beneath it.
Changes
ModuleConfiguration.tsx: add an optionalsensitiveVariables?: TemplateBuilderModuleVariable[]prop and render the info note at the bottom of the grey card, after the "Additional settings" collapsible / "No configuration required." block. Code chips usebg-surface-tertiaryso they don't blend into the grey (bg-surface-secondary) card.ModuleSettingsStep.tsx: passsensitiveVariables={sensitiveVars}and remove the sibling note<div>(and the now-unusedInfoIconimport).ModuleConfiguration.stories.tsx: addWithSensitiveVariablesandNoConfigWithSensitiveVariablesstories withplayassertions on the note, covering both the "has optional fields" and "no configuration required" branches.No behavior change beyond the note's location and styling.
Testing
pnpm check(biome) cleanpnpm lint:types(tsc) cleanpnpm vitest run --project=storybook src/pages/TemplateBuilder/ModuleConfiguration— 6 passpnpm vitest run --project=unit src/pages/TemplateBuilder— 61 passContext: remaining #27077 items
#27077 bundled four items. Items 2 (navigable sidebar) and 4 (trash-icon removal) shipped separately (#27351, #28153, plus item 4 already on
main). Item 1 (gallery height / card sizing) was effectively superseded by #27437 (removed inner-scroll containers) and #27797 (grid + card typography), so it is intentionally not ported. This PR handles item 3, the last remaining piece.Coder Agents generated, on behalf of @aqandrew.