Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: deliver the rest of the invalid_request class to the client #28736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BobbyHo merged 121 commits into from
Sep 3, 2026
Merged

fix: deliver the rest of the invalid_request class to the client #28736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
121 commits
Select commit Hold shift + click to select a range
a672066
feat(coderd/rbac): compare scopes by permission coverage
BobbyHo Aug 14, 2026
4315706
Merge branch 'main' into plat479-1-rbac-scope-coverage
BobbyHo Aug 17, 2026
787c461
docs(coderd/rbac): shorten the ScopesCover doc comment
BobbyHo Aug 17, 2026
2d39e04
Merge branch 'main' into plat479-1-rbac-scope-coverage
BobbyHo Aug 18, 2026
2f6c44e
fix(coderd/rbac): guard allowed-side org and user permissions
BobbyHo Aug 18, 2026
bd40270
refactor(coderd/rbac): drop the unreachable negative skip in coverage
BobbyHo Aug 18, 2026
3139c54
test(coderd/rbac): pin the scope coverage table's weak assertions
BobbyHo Aug 18, 2026
9276bb8
refactor(coderd/rbac): make the coverage guards reachable from tests
BobbyHo Aug 18, 2026
865eb9a
refactor(coderd/rbac): share the alias table and name the canonical c…
BobbyHo Aug 18, 2026
26a6bed
docs(coderd/rbac): document the expansion invariant where it can be b…
BobbyHo Aug 18, 2026
7cca7b3
Merge branch 'main' into plat479-1-rbac-scope-coverage
BobbyHo Aug 19, 2026
1678a77
test(coderd/rbac): pin the coverage guards at one strength
BobbyHo Aug 19, 2026
aba3c6c
fix(coderd/rbac): name the scope once in expansion errors
BobbyHo Aug 19, 2026
9a08105
docs(coderd/rbac): correct the external scope list contract
BobbyHo Aug 19, 2026
2fcce8b
docs(coderd/rbac): trim the restated coverage invariant
BobbyHo Aug 19, 2026
a775a48
docs(coderd/rbac): correct the negative permission cross-reference
BobbyHo Aug 19, 2026
e0c0d4a
docs(coderd/rbac): name every category IsExternalScope admits
BobbyHo Aug 19, 2026
189740d
test(coderd/rbac): pin the alias list invariants on the alias table
BobbyHo Aug 19, 2026
7d08e49
Merge branch 'main' into plat479-1-rbac-scope-coverage
BobbyHo Aug 19, 2026
ca4dc52
feat(coderd/oauth2provider): negotiate and persist authorization scope
BobbyHo Aug 14, 2026
f402e1a
feat(site): state the negotiated scope on the OAuth2 consent page
BobbyHo Aug 14, 2026
28ef5ba
fix(coderd/oauth2provider): return invalid_scope to the client's call…
BobbyHo Aug 14, 2026
62950d3
test(coderd/rbac): close two mutation gaps in scope coverage tests
BobbyHo Aug 20, 2026
554a703
Merge branch 'main' into plat479-2-negotiate-scope
BobbyHo Aug 20, 2026
09bc1b4
refactor(coderd/oauth2provider): rename validateRequestedScope to neg…
BobbyHo Aug 21, 2026
6fe6c71
test(coderd/oauth2provider): bind the wire-level scope reasons to the…
BobbyHo Aug 21, 2026
e296dda
refactor(coderd): log undecidable oauth2 scope coverage instead of re…
BobbyHo Aug 21, 2026
2760db5
fix(coderd/oauth2provider): name the stored allowlist when none of it…
BobbyHo Aug 21, 2026
5b2ca57
refactor(coderd/oauth2provider): reword the oauth2 scope rejection re…
BobbyHo Aug 21, 2026
90a6f83
docs: correct what the oauth2 authorize scope parameter promises
BobbyHo Aug 21, 2026
77654a1
test(coderd/oauth2provider): fold the no-allowlist guarantee into one…
BobbyHo Aug 21, 2026
dfdd33f
Merge branch 'plat479-2-negotiate-scope' into plat479-3-report-negoti…
BobbyHo Aug 22, 2026
ba8a123
Merge branch 'main' into plat479-2-negotiate-scope
BobbyHo Aug 22, 2026
bc40908
test(coderd): close the consent-page and state-echo test gaps
BobbyHo Aug 23, 2026
cb7df2e
fix(site/static): left-align the consent permission list
BobbyHo Aug 23, 2026
41e9f40
fix(coderd/oauth2provider): validate the callback scheme before any r…
BobbyHo Aug 23, 2026
a56cdac
fix(coderd/oauth2provider): replace callback query params instead of …
BobbyHo Aug 23, 2026
009962c
feat: say that the consent permission names are technical
BobbyHo Aug 23, 2026
efbeefb
fix(coderd/oauth2provider): deliver three more authorize errors to th…
BobbyHo Aug 23, 2026
f983335
fix: state unrestricted OAuth2 consent in its own field
BobbyHo Aug 23, 2026
f22da3a
Merge branch 'plat479-3-report-negotiated-scope' into plat479-4-conso…
BobbyHo Aug 23, 2026
81bbfb0
docs: trim OAuth2 scope negotiation comments
BobbyHo Aug 23, 2026
b7f88f0
Merge branch 'plat479-2-negotiate-scope' into plat479-3-report-negoti…
BobbyHo Aug 23, 2026
2a2e006
Merge branch 'main' into plat479-2-negotiate-scope
BobbyHo Aug 23, 2026
a11d42c
test(coderd/oauth2provider): pin the consent list semantics and the s…
BobbyHo Aug 23, 2026
eb37c2f
test(coderd/oauth2provider): cover the error redirect in the query-pa…
BobbyHo Aug 23, 2026
a5e3f94
fix(coderd/oauth2provider): answer 500 and log on an unusable callbac…
BobbyHo Aug 23, 2026
60cbe59
fix: refuse to render a consent page for a grant with no permissions
BobbyHo Aug 23, 2026
fdc9532
docs: document invalid_scope rejections on the authorize endpoint
BobbyHo Aug 23, 2026
8e88730
Merge branch 'plat479-3-report-negotiated-scope' into plat479-4-conso…
BobbyHo Aug 24, 2026
e63ff3a
docs(coderd): trim the scope test comments
BobbyHo Aug 25, 2026
a9ade4a
Merge branch 'plat479-2-negotiate-scope' into plat479-3-report-negoti…
BobbyHo Aug 25, 2026
5589bf6
docs: trim the consent page and error redirect comments
BobbyHo Aug 25, 2026
24b4f46
docs(coderd): drop the godoc-style comments from the scope tests
BobbyHo Aug 25, 2026
b92b7f9
docs(coderd/oauth2provider): trim the authorize.go comments
BobbyHo Aug 25, 2026
e4cc41d
Merge branch 'plat479-2-negotiate-scope' into plat479-3-report-negoti…
BobbyHo Aug 25, 2026
20caa9c
docs(coderd): trim the scope reporting test comments
BobbyHo Aug 25, 2026
c7d3d53
docs(site): trim the consent page scope comments
BobbyHo Aug 25, 2026
d0beb1e
Merge remote-tracking branch 'origin/plat479-3-report-negotiated-scop…
BobbyHo Aug 25, 2026
8a5004a
docs(coderd/oauth2provider): trim the redirect consolidation comments
BobbyHo Aug 25, 2026
78fbab1
Merge branch 'main' into plat479-2-negotiate-scope
BobbyHo Aug 26, 2026
f675cf1
fix(site/static): make the whole consent page reachable by scrolling
BobbyHo Aug 27, 2026
1e746ef
Merge branch 'plat479-3-report-negotiated-scope' into plat479-4-conso…
BobbyHo Aug 27, 2026
7b9e3e1
fix(coderd/oauth2provider): restrict error_description to NQSCHAR
BobbyHo Aug 27, 2026
913ac42
fix(coderd/httpapi): stop RedirectURL panicking on an unparsable URL
BobbyHo Aug 27, 2026
85e81d2
fix(coderd/oauth2provider): drop registered response params from the …
BobbyHo Aug 27, 2026
f1b6e1b
fix(coderd/oauth2provider): reject a plain code_challenge_method on GET
BobbyHo Aug 27, 2026
f16172c
fix(coderd/oauth2provider): log authorization failures server side
BobbyHo Aug 27, 2026
0a71888
docs(coderd/oauth2provider): correct the claims the redirect comments…
BobbyHo Aug 27, 2026
946f975
refactor(coderd/oauth2provider): name the callback the same at both l…
BobbyHo Aug 27, 2026
af47eee
test(coderd/oauth2provider): assert plain PKCE through one contract
BobbyHo Aug 27, 2026
57eac6d
test(coderd/oauth2provider): tidy the authorize test helpers
BobbyHo Aug 27, 2026
0afcbf8
docs: describe the authorize endpoint's error redirect in swagger
BobbyHo Aug 27, 2026
c1f9d1e
docs(docs/admin/integrations): document the errors now sent to the ca…
BobbyHo Aug 27, 2026
6fbce5d
docs(coderd/oauth2provider): trim the authorize comments
BobbyHo Aug 27, 2026
2ec3bdb
refactor(coderd/oauth2provider): run both callback preconditions at c…
BobbyHo Aug 27, 2026
90be3d1
fix(coderd/oauth2provider): deliver the rest of the invalid_request c…
BobbyHo Aug 27, 2026
ffcaa33
docs(docs/admin/integrations): document the redirected parameter errors
BobbyHo Aug 27, 2026
a68a32d
docs: stop advertising response_type=token in the API reference
BobbyHo Aug 27, 2026
ceb3997
Update coderd/oauth2provider/authorize.go
BobbyHo Aug 31, 2026
2cd9b60
Update coderd/oauth2provider/authorize.go
BobbyHo Aug 31, 2026
d160bda
docs(coderd/oauth2provider): trim the errNoGrantableScope comment
BobbyHo Aug 31, 2026
b60eee6
refactor(coderd/oauth2provider): canonicalize scopes before the catal…
BobbyHo Aug 31, 2026
4732d1f
refactor(coderd/oauth2provider): canonicalize the allowlist in one pass
BobbyHo Aug 31, 2026
03df6a9
test(coderd/rbac): pin the field sets scope coverage reads
BobbyHo Aug 31, 2026
a2d2856
docs(coderd/rbac): trim the TestCoverageModelFields comment
BobbyHo Aug 31, 2026
d83636b
Merge branch 'plat479-2-negotiate-scope' into plat479-3-report-negoti…
BobbyHo Aug 31, 2026
037e744
Merge remote-tracking branch 'origin/main' into plat479-3-report-nego…
BobbyHo Aug 31, 2026
2442461
Merge branch 'plat479-3-report-negotiated-scope' into plat479-4-conso…
BobbyHo Aug 31, 2026
83568af
Merge branch 'plat479-4-consolidate-redirects' into plat479-5-deliver…
BobbyHo Aug 31, 2026
433e449
docs(coderd/oauth2provider): trim scope negotiation comments
BobbyHo Aug 31, 2026
ef978b6
Merge branch 'plat479-3-report-negotiated-scope' into plat479-4-conso…
BobbyHo Aug 31, 2026
35ce008
Merge branch 'main' into plat479-3-report-negotiated-scope
BobbyHo Aug 31, 2026
3bcca75
Merge branch 'plat479-4-consolidate-redirects' into plat479-5-deliver…
BobbyHo Aug 31, 2026
48d9c7f
fix(coderd/oauth2provider): return server_error for undecidable scope…
BobbyHo Sep 1, 2026
506d39a
Merge branch 'plat479-3-report-negotiated-scope' into plat479-4-conso…
BobbyHo Sep 1, 2026
5c4ffba
Merge branch 'plat479-4-consolidate-redirects' into plat479-5-deliver…
BobbyHo Sep 1, 2026
874b1e0
Merge branch 'main' into plat479-4-consolidate-redirects
BobbyHo Sep 1, 2026
f986619
Merge branch 'plat479-4-consolidate-redirects' into plat479-5-deliver…
BobbyHo Sep 1, 2026
b681f18
Merge branch 'main' into plat479-4-consolidate-redirects
BobbyHo Sep 1, 2026
01f02a8
docs(coderd/oauth2provider): trim the sanitize and redirect comments
BobbyHo Sep 1, 2026
a599fa8
Merge branch 'plat479-4-consolidate-redirects' into plat479-5-deliver…
BobbyHo Sep 1, 2026
d59dd1a
Merge remote-tracking branch 'origin/plat479-4-consolidate-redirects'…
BobbyHo Sep 1, 2026
f2a634f
Merge branch 'plat479-4-consolidate-redirects' into plat479-5-deliver…
BobbyHo Sep 1, 2026
98ddbae
fix(coderd/oauth2provider): decide the carve-out from the resolved app
BobbyHo Sep 1, 2026
127ba5f
fix(coderd/oauth2provider): charge a state failure to the client, not…
BobbyHo Sep 1, 2026
796a8ad
fix(coderd/oauth2provider): ignore unrecognized authorization parameters
BobbyHo Sep 1, 2026
02615f1
fix(coderd/oauth2provider): give every unsupported response_type one …
BobbyHo Sep 1, 2026
0dcbfdc
fix(coderd/oauth2provider): answer invalid_target for a malformed res…
BobbyHo Sep 1, 2026
e212f2e
fix(coderd/oauth2provider): make error_description readable and bounded
BobbyHo Sep 1, 2026
3e3d1ba
docs: correct the /oauth2/authorize parameter reference
BobbyHo Sep 1, 2026
3713c99
docs(docs/admin/integrations): match the authorize error prose to the…
BobbyHo Sep 1, 2026
4ef2101
Merge remote-tracking branch 'origin/plat479-5-deliver-invalid-reques…
BobbyHo Sep 1, 2026
ac151b2
refactor(coderd/oauth2provider): give authorizeFailure the dispatch
BobbyHo Sep 1, 2026
b9a9e15
refactor(coderd/oauth2provider): name the callback accessor for what …
BobbyHo Sep 1, 2026
e58e918
docs(coderd/oauth2provider): correct the authorizeFailure comments
BobbyHo Sep 1, 2026
cc7ddc0
test(coderd/oauth2provider/oauth2providertest): assert what the rejec…
BobbyHo Sep 1, 2026
8ac6862
docs: document the /oauth2/authorize failure responses
BobbyHo Sep 1, 2026
1145d35
docs(docs/admin/integrations): name both unusable-callback causes
BobbyHo Sep 1, 2026
3df45f9
Merge branch 'main' into plat479-5-deliver-invalid-request
BobbyHo Sep 2, 2026
b172782
fix(coderd/oauth2provider): deliver the failure for a valueless clien…
BobbyHo Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 116 additions & 10 deletions coderd/apidoc/docs.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

118 changes: 110 additions & 8 deletions coderd/apidoc/swagger.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading