fix(site): dispose Monaco diff models on unmount (#28503) - #28809
Merged
Conversation
Backport of #28503 to release/2.37. `SyntaxHighlighter` sets `keepCurrentOriginalModel` / `keepCurrentModifiedModel`, so `@monaco-editor/react` never disposes the diff editor's text models. Without stable model paths, every render of a template version created fresh anonymous models that were never freed, so navigating between versions leaked models until the tab hung. Move the diff editor into a `DiffFile` component that captures the original and modified models in `onMount` and disposes them when the diff editor unmounts, including the diff to plain switch while `SyntaxHighlighter` stays mounted. Disposal is deferred with `queueMicrotask` because freeing the models in the same synchronous teardown throws `TextModel got disposed before DiffEditorWidget model got reset`. The `keepCurrent*Model` flags stay, since removing them reintroduces that mid-teardown throw. Adds `SyntaxHighlighter.stories.tsx` with a `DisposesModelsOnDiffToggle` play test asserting the model count returns to baseline across diff and plain toggles. (cherry picked from commit 5008603)
jakehwll
marked this pull request as ready for review
September 1, 2026 07:30
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mtojek
self-requested a review
September 1, 2026 07:37
mtojek
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28503 to
release/2.37.Refs DEVEX-736. This carries the Monaco diff-model lifecycle cleanup and Storybook regression coverage into 2.37, preventing template-version navigation from retaining models until the editor becomes unusable.
The original patch applies cleanly to this release branch.